chore: bump more rand deps to 0.10 - #10556
Open
Jefffrey wants to merge 5 commits into
Open
Conversation
Jefffrey
commented
Aug 5, 2026
Jefffrey
commented
Contributor
- Followup to chore: update some dev deps rand to 0.10 #10537
- Part of chore(deps): bump rand from 0.9.5 to 0.10.2 #10192
github-actions
Bot
added
parquet
Jefffrey
commented
Aug 5, 2026
Jefffrey
left a comment
Jefffrey
left a comment
Contributor
Author
There was a problem hiding this comment.
There'll be one final followup, which will be the actual breaking change; all these changes so far are not visible in any of our APIs
| ), | ||
| 18 => Arc::new(generate_boolean_array(rng, len, 0.8)), | ||
| 19 => Arc::new(generate_list_view( | ||
| &mut rng.clone(), |
Contributor
Author
There was a problem hiding this comment.
they removed Clone from StdRng so restructured this code a little
|
|
||
| use arrow::array::{Array, ArrayRef, BinaryViewArray, BinaryViewBuilder, StringArray, StructArray}; | ||
| use arrow::buffer::Buffer; | ||
| use arrow::util::test_util::seedable_rng; |
Contributor
Author
There was a problem hiding this comment.
because we had this dependency, rand dependency of parquet-variant-compute was tied to the rand dependency in arrow; decouple them since its calling this single function, makes upgrading easier in the future
|
|
||
| fn encoded_meta(is_nullable: bool, has_lists: bool, write_path_in_schema: bool) -> Vec<u8> { | ||
| let mut rng = seedable_rng(); | ||
| let mut rng = StdRng::seed_from_u64(42); |
Contributor
Author
There was a problem hiding this comment.
same issue here for parquet; however we still need the dependency since we use other functions from arrow test_util; so long as we don't use any that exposes rand
Jefffrey
marked this pull request as draft
August 5, 2026 00:50
Jefffrey
marked this pull request as ready for review
August 5, 2026 01:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.