Move arrow_writer_layout.rs into arrow_writer/layout.rs - #10542
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
alamb
force-pushed
the
alamb/consolidate_layout_tests
branch
from
August 4, 2026 14:19
e19c5d2 to
8aba23d
Compare
alamb
marked this pull request as ready for review
August 4, 2026 14:20
Contributor
Author
|
Thanks @etseidl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Consolidate the scattered parquet end-to-end tests: the
ArrowWriterpage layout tests belong with the otherarrow_writerintegration tests rather than in a separate test binary.What changes are included in this PR?
parquet/tests/arrow_writer.rstoparquet/tests/arrow_writer/mod.rsparquet/tests/arrow_writer_layout.rstoparquet/tests/arrow_writer/layout.rs(unchanged, now a submodule)arrow_writer_layouttest target fromCargo.tomlAre these changes tested?
Yes, this PR only moves existing tests. All 14 tests pass via
cargo test -p parquet --features arrow --test arrow_writer.Are there any user-facing changes?
No, test-only change.
🤖 Generated with Claude Code