Skip to content

Refactoring test resource files to remove 1 TODO#6444

Merged
DomGarguilo merged 6 commits into
apache:mainfrom
Amemeda:more-file-refactoring
Jul 1, 2026
Merged

Refactoring test resource files to remove 1 TODO#6444
DomGarguilo merged 6 commits into
apache:mainfrom
Amemeda:more-file-refactoring

Conversation

@Amemeda

@Amemeda Amemeda commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
  • Removing "# TODO: these test resources should be moved into the correct package for the module" from line 59 of check-module-packaging-conventions.sh
  • moved groups of test files into new org/apache/accumulo/.. packages to match the module
  • refactor updated file paths references across java test files.

original file paths:
core/src/test/resources/accumulo.jceks
core/src/test/resources/empty.jceks
core/src/test/resources/site-cfg.jceks
core/src/test/resources/accumulo2.properties
core/src/test/resources/passwords.jceks
minicluster/src/test/resources/FooFilter.jar
server/tserver/src/test/resources/walog-from-15.walog
server/tserver/src/test/resources/walog-from-16.walog
server/tserver/src/test/resources/walog-from-14/550e8400-e29b-41d4-a716-446655440000
server/tserver/src/test/resources/walog-from-20.walog
test/src/main/resources/v2_import_test/README.md
test/src/main/resources/v2_import_test/data/A0000008.rf
test/src/main/resources/v2_import_test/data/A0000009.rf
test/src/main/resources/v2_import_test/data/A000000a.rf
test/src/main/resources/v2_import_test/data/A000000b.rf
test/src/main/resources/v2_import_test/data/distcp.txt
test/src/main/resources/v2_import_test/data/exportMetadata.zip

@Amemeda

Amemeda commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

This pr resovles 1 TODO from #2699

@Amemeda Amemeda marked this pull request as ready for review June 24, 2026 15:48
@Amemeda Amemeda marked this pull request as draft June 24, 2026 21:26
@Amemeda Amemeda marked this pull request as ready for review June 25, 2026 14:17
Amemeda and others added 4 commits June 26, 2026 14:36
* Relocate misplaced test resources under their module package namespaces.
* Update resource lookups and license/RAT excludes.
* Fix WAL test temp-file handling for nested resource paths.
@DomGarguilo

Copy link
Copy Markdown
Member

Found and fixed a few more issues with these changing paths in d74edfb

@DomGarguilo DomGarguilo merged commit 618addf into apache:main Jul 1, 2026
@ctubbsii ctubbsii added this to the 4.0.0 milestone Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants