fix(ci): harden actions against pwn request vulnerabilities#204
Open
mjohns91 wants to merge 2 commits into
Open
fix(ci): harden actions against pwn request vulnerabilities#204mjohns91 wants to merge 2 commits into
mjohns91 wants to merge 2 commits into
Conversation
Upgrade actions/checkout v3->v7 and actions/setup-python v4->v7 to resolve Node 20 deprecation and enable built-in pwn request protection. Move attacker-controllable inputs from direct shell interpolation to env variables to prevent script injection. Add persist-credentials: false to prevent token leakage via .git/config. Files changed: - commit_to_pullrequest/action.yml - ansible_validate_changelog/action.yml - workflows/changelog.yml Assisted-by: Claude Opus 4.6
Pin actions/checkout and actions/setup-python to their v7.0.0 commit SHAs to prevent supply-chain attacks via tag mutation. Assisted-by: Claude Opus 4.6
mjohns91
marked this pull request as ready for review
July 24, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutv3→v7 andactions/setup-pythonv4→v7 to resolve Node 20 deprecation and enable built-in pwn request protection${{ }}shell interpolation toenv:variables to prevent script injectionpersist-credentials: falseto prevent token leakage via.git/configDetails
Applies security hardening patterns from the GitHub Security Lab blog post on preventing pwn requests to three files:
commit_to_pullrequest/action.ymlgithub.head_refscript injection ingit pushcommand (attacker-controlled branch name)inputs.commit_message,inputs.file_pattern,inputs.python_libs,inputs.python_executable_url— all moved from direct shell interpolation to env varspersist-credentials: falseandallow-unsafe-pr-checkout: true(required because this action legitimately checks out fork PR code to commit back)ansible_validate_changelog/action.ymlinputs.base_refandinputs.custom_pathsinjection — moved from direct shell interpolation to env varsworkflows/changelog.ymlpersist-credentials: falseto checkout stepNo breaking changes
The
inputs:interface for all actions/workflows is unchanged. Callers require no modifications.Test plan
${{ }}expressions remain inrun:stepsupdate_aws_variablesworkflow succeeds on a test PR in amazon.aws🤖 Generated with Claude Code