docs(sandbox): drop the stale Cloud Run launcher rationale from GCP comments - #490
Closed
ItamarZand88 wants to merge 1 commit into
Closed
docs(sandbox): drop the stale Cloud Run launcher rationale from GCP comments#490ItamarZand88 wants to merge 1 commit into
ItamarZand88 wants to merge 1 commit into
Conversation
…omments The GCP sandbox is an Agent Platform engine and template, not a Cloud Run launcher subprocess. Five comments still explained the AWS-only remote-sandbox, the permission-reach scans and the Kubernetes metadata denial through that old model; restate the real invariant — remote sandbox has only an AWS binding and the platform gate refuses GCP — without the obsolete mechanism.
Greptile SummaryThis PR updates stale sandbox documentation without changing executable behavior.
Confidence Score: 5/5The PR appears safe to merge because it changes documentation comments only and preserves the existing runtime behavior. The revised comments remain consistent with the adjacent AWS-only checks, GCP refusal path, and Kubernetes metadata-server isolation logic; no executable code or public contract changes.
|
| Filename | Overview |
|---|---|
| crates/alien-helm/src/emitters/sandbox.rs | Rewords the metadata-server isolation comment while preserving the Kubernetes-specific rationale. |
| crates/alien-manager/src/routes/bindings.rs | Replaces the obsolete Cloud Run launcher explanation with the current AWS-only binding and authorization rationale. |
| crates/alien-permissions/src/registry.rs | Clarifies that the permission scan identifies AWS MicroVM-session verbs and does not apply to other cloud stack grants. |
| crates/alien-preflights/src/mutations/remote_bindings.rs | Updates reachability documentation and test commentary to describe the GCP platform gate without referencing removed launcher behavior. |
Reviews (1): Last reviewed commit: "docs(sandbox): drop the stale Cloud Run ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GCP sandbox is an Agent Platform engine and template, but several comments still
explained the AWS-only remote-sandbox and permission-reach rules as if GCP were a Cloud Run
launcher subprocess. This rewords them to state the real reason — remote sandbox has only an
AWS binding and the platform gate refuses GCP — without the obsolete mechanism.
What I did
sandbox is AWS-only; the platform gate refuses GCP; a Kubernetes sandbox must deny the
metadata server itself) and dropping the Cloud Run launcher description.
GcpSandboxLauncherMutationand blanketsandboxLaunchergrant theold comments named no longer exist.
Files touched
alien-manager/src/routes/bindings.rs— the remote-sandbox AWS-only rationale.alien-permissions/src/registry.rs— the MicroVM-session permission-reach scan.alien-preflights/src/mutations/remote_bindings.rs— a reachability note and a test's doc.alien-helm/src/emitters/sandbox.rs— the metadata-server block, named as the managedruntime rather than a cloud (which kept it consistent with the GKE note below it).
How I tested
gate and the GCP refusal are unchanged.