Skip to content

fix(cli): render structured log messages - #485

Merged
alongubkin merged 2 commits into
mainfrom
alon/alien-569-readable-structured-logs
Aug 24, 2026
Merged

fix(cli): render structured log messages#485
alongubkin merged 2 commits into
mainfrom
alon/alien-569-readable-structured-logs

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • render the human message from structured tracing records stored as JSON strings
  • retain the complete source hit in the stable raw field
  • leave generic JSON messages untouched

Testing

  • cargo test -p alien-cli commands::logs::tests

Linear: ALIEN-569

@alongubkin
alongubkin force-pushed the alon/alien-569-readable-structured-logs branch from 102cf53 to 540e645 Compare August 24, 2026 09:35
@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown

Greptile Summary

The PR narrows structured tracing-record detection so ordinary JSON matching the previously reported shape remains intact.

  • Requires a string target alongside timestamp, level, and fields.message before extracting the human-readable message.
  • Preserves the complete source hit in raw.
  • Adds tests for tracing extraction and generic-JSON fallback.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
crates/alien-cli/src/commands/logs.rs Adds a stricter tracing JSON classifier and regression coverage, resolving the previously reported generic-JSON case without an eligible new blocking finding.

Reviews (2): Last reviewed commit: "fix(cli): require tracing record target" | Re-trigger Greptile

Comment thread crates/alien-cli/src/commands/logs.rs
@alongubkin

Copy link
Copy Markdown
Member Author

Verified the final behavior and review fixes:

  • recognized tracing records render a readable message
  • generic JSON remains unchanged
  • complete source data remains available
  • focused regression tests pass
  • Greptile completed at 5/5 with no blocking findings

Ready to merge.

@alongubkin
alongubkin merged commit eff8c2f into main Aug 24, 2026
24 checks passed
@alongubkin
alongubkin deleted the alon/alien-569-readable-structured-logs branch August 24, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant