fix: use configured model provider on session resume#224
Open
david-melville wants to merge 1 commit into
Open
Conversation
When resuming or loading a session, getResumeModelProvider() now reads the model_provider value from Codex config (config/read) before falling back to "openai". This fixes a v1.0.0 regression where sessions resumed via ACP always used OpenAI even when ~/.codex/config.toml specified model_provider = "azure".
|
Thanks for the fix. I've run into the same issue on my side as well. It would be greatly appreciated if this could be merged and released soon. @benbrandt Looking forward to seeing this fix included in an upcoming release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When resuming or loading a session, ACP's
getResumeModelProvider()returned"openai"as a hardcoded fallback wheneverMODEL_PROVIDERwas not set in the environment — even if~/.codex/config.tomlexplicitly setmodel_provider = "azure".This is a v1.0.0 regression: Codex itself reads the config correctly (verified via
config/read), but the ACP adapter overrode it on resume/load.Fix
getResumeModelProvider()now awaits an async lookup of the configured provider (viaconfig/read) before falling back to"openai". BothresumeSessionandloadSessionpass the resolved provider.Testing
Related: #164