Skip to content

Membership's document#1024

Open
Rotheem wants to merge 21 commits into
mainfrom
membership-document
Open

Membership's document#1024
Rotheem wants to merge 21 commits into
mainfrom
membership-document

Conversation

@Rotheem

@Rotheem Rotheem commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description

Summary

Support document requirement for memberships

Issues/PR dependencies

Issues to be resolved

Required PRs

Depends on : #1023

Changes Made

  • link membership to document template
  • create document on membership creation
  • delete document on membership deletion
  • adapt CDR
  • adapt MyPayment
  • add tests

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.42344% with 132 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.31%. Comparing base (bff3008) to head (0c8813e).

Files with missing lines Patch % Lines
app/core/documents/documenso_api_wrapper.py 35.08% 37 Missing ⚠️
app/core/memberships/utils_memberships.py 48.07% 27 Missing ⚠️
app/core/memberships/endpoints_memberships.py 34.21% 25 Missing ⚠️
app/core/documents/utils_documents.py 86.95% 9 Missing ⚠️
app/core/documents/exceptions_documents.py 65.21% 8 Missing ⚠️
app/modules/cdr/endpoints_cdr.py 27.27% 8 Missing ⚠️
app/core/documents/endpoints_documents.py 96.65% 7 Missing ⚠️
app/modules/cdr/exception_cdr.py 55.55% 4 Missing ⚠️
app/core/memberships/cruds_memberships.py 72.72% 3 Missing ⚠️
app/core/users/cruds_users.py 66.66% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
- Coverage   84.42%   84.31%   -0.12%     
==========================================
  Files         206      216      +10     
  Lines       14948    15664     +716     
==========================================
+ Hits        12620    13207     +587     
- Misses       2328     2457     +129     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant