Skip to content

fix: resolve undici GHSA-vrm6-8vpv-qv8q via npm overrides#265

Open
adrienpessu with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-undici-memory-vulnerability
Open

fix: resolve undici GHSA-vrm6-8vpv-qv8q via npm overrides#265
adrienpessu with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-undici-memory-vulnerability

Conversation

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Undici ≤5.29.0 is vulnerable to a DoS via unbounded memory growth during WebSocket permessage-deflate decompression (GHSA-vrm6-8vpv-qv8q / CVE-2026-1526). undici is a transitive dep of @actions/github@6.0.0, which pins it at ^5.25.4.

Changes

  • .github/action/package.json — adds an overrides entry to force undici >=6.24.0 without bumping @actions/github across a major version boundary:
    "overrides": {
      "undici": ">=6.24.0"
    }
  • .github/action/package-lock.json — regenerated; undici now resolves to 8.5.0.

Reachability

Not reachable. The vulnerability is specific to WebSocket clients using the permessage-deflate extension. This codebase makes no WebSocket connections — undici is only exercised via @actions/github for plain HTTP calls to the GitHub API. Update is scanner hygiene, not active risk mitigation. High confidence.

Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>Undici has Unbounded Memory Consumption in WebSocket permessage-deflate Decompression</alert_title>
<alert_description>## Description

The undici WebSocket client is vulnerable to a denial-of-service attack via unbounded memory consumption during permessage-deflate decompression. When a WebSocket connection negotiates the permessage-deflate extension, the client decompresses incoming compressed frames without enforcing any limit on the decompressed data size. A malicious WebSocket server can send a small compressed frame (a "decompression bomb") that expands to an extremely large size in memory, causing the Node.js process to exhaust available memory and crash or become unresponsive.

The vulnerability exists in the PerMessageDeflate.decompress() method, which accumulates all decompressed chunks in memory and concatenates them into a single Buffer without checking whether the total size exceeds a safe threshold.

Impact

  • Remote denial of service against any Node.js application using undici's WebSocket client
  • A single compressed WebSocket frame of ~6 MB can decompress to ~1 GB or more
  • Memory exhaustion occurs in native/external memory, bypassing V8 heap limits
  • No application-level mitigation is possible as decompression occurs before message delivery

Patches

Users should upgrade to fixed versions.

Workarounds

No workaround are possible.</alert_description>

high
GHSA-vrm6-8vpv-qv8q, CVE-2026-1526
undici
npm
<vulnerable_versions>5.29.0</vulnerable_versions>
<patched_version>6.24.0</patched_version>
<manifest_path>.github/action/package-lock.json</manifest_path>

https://github.com/nodejs/undici/security/advisories/GHSA-vrm6-8vpv-qv8q https://nvd.nist.gov/vuln/detail/CVE-2026-1526 https://hackerone.com/reports/3481206 https://cna.openjsf.org/security-advisories.html https://datatracker.ietf.org/doc/html/rfc7692 https://owasp.org/www-community/attacks/Denial_of_Service https://github.com/advisories/GHSA-vrm6-8vpv-qv8q

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), do...

Copilot AI requested review from Copilot and removed request for Copilot July 2, 2026 13:18
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 1b1ff06.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copilot AI requested review from Copilot and removed request for Copilot July 2, 2026 13:30
Copilot AI changed the title [WIP] Fix undici unbounded memory consumption in WebSocket fix: resolve undici GHSA-vrm6-8vpv-qv8q via npm overrides Jul 2, 2026
Copilot AI requested a review from adrienpessu July 2, 2026 13:30
@adrienpessu adrienpessu marked this pull request as ready for review July 2, 2026 13:33
Copilot AI review requested due to automatic review settings July 2, 2026 13:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants