fix(security): bound hosted Addie auth probes - #6109
Draft
bokelley wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Both hosted auth-grader tools exposed
allow_http, which mapped directly to the SDK/CLI private-network override. The signing grader also allowed callers to request live vectors and had no cross-request process bound; ordinary authenticated users could launch multiple long-lived child processes. Its custom capability probe preflight-resolved DNS and then used globalfetch, leaving a DNS-rebinding gap.Impact
Hosted Addie now probes only public HTTPS agents. Trusted private development loops and explicit live-vector testing remain available through the local SDK CLI. Signing grades are capped at two concurrent children per server, with per-user and service-wide limits; excess work fails fast with a retry message.
Validation
No changeset is required because this is an operational Addie/server security fix with no protocol-package API change.