fix(security): require signed Slack webhooks - #6108
Draft
bokelley wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The shared Slack verifier called
next()whenSLACK_SIGNING_SECRETwas absent, while the events route conditionally skipped verification entirely. That allowed public forged commands and events to reach handlers, including identity and prospect-processing side effects.Impact
Deployments without a configured AAO Slack signing secret now return
503from those webhook routes instead of accepting unsigned traffic. Correctly configured Slack requests continue to work, including signed URL verification challenges.Validation
No changeset is required because this is an operational server security fix with no protocol or package API change.