Use new error structure - #1502
Open
robbevp wants to merge 7 commits into
Open
Conversation
robbevp
force-pushed
the
enhc/use-structured-errors
branch
from
July 25, 2026 12:09
969af16 to
c2e58f5
Compare
chvp
reviewed
Jul 31, 2026
Comment on lines
+9
to
+10
| <strong>{{ I18n.t(`errors.types.${error.name}`, error.name) }}:</strong | ||
| > |
Member
There was a problem hiding this comment.
Suggested change
| <strong>{{ I18n.t(`errors.types.${error.name}`, error.name) }}:</strong | |
| > | |
| <strong>{{ I18n.t(`errors.types.${error.name}`, error.name) }}:</strong> | |
| |
I'm allergic to these unnecessary no-whitespace-preserving prettier fixes 😅
| }, | ||
| "models": { | ||
| "auth_token": { | ||
| "base": { |
Member
There was a problem hiding this comment.
Indentation seems wrong here? Not necessarily for this PR, but can we check formatting in CI?
| const confirmationMatch = (v: string): true | string => | ||
| (!!v && v) === newUser.value.password || | ||
| I18n.t("errors.user.password-confirmation"); | ||
| I18n.t("errors.user.password_confirmation"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on accentor/api-client-js#821 and accentor/api#722
This updates web to work with the new structure or errors from the api and the way api-client-js wraps these in error classes.
PlayerError)We end up with quite a few less translations inside
errorssince we no longer have a key for each model.I18n.twith an error messageI did a bunch of test to check that I got the output I expected, but far from covered all possibilities and error cases.