#385 - added null check on SqlTimeConverter

[aaberg]

No description provided.

[Copilot]

🟡 Changes recommended

The new test file has a minor but potentially build-breaking unused import and deviates from established test class visibility conventions in this package.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR addresses issue #385 by making SqlTimeConverter explicitly handle null inputs, preventing a potential NullPointerException and aligning behavior with other converters that return null for null input.

Changes:

• Add an explicit null guard in SqlTimeConverter.convert(...).
• Add a new JUnit 5 test suite covering supported input types (including null) and unsupported input behavior.

File summaries

File	Description
core/src/main/java/org/sql2o/converters/SqlTimeConverter.java	Adds an early null return in convert(...) to avoid NPE and define null-handling behavior.
core/src/test/java/org/sql2o/converters/SqlTimeConverterTest.java	Introduces parameterized tests for supported conversions (including null) and a test for unsupported input.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.