feat: Add filters for data table#695
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a faceted multi-select filtering feature to the DataTable component, allowing both static and async (server-side) filtering. It also adds role-based filtering for the admin users list, search support for the admin roles list, and updates the documentation and localization files accordingly. The review feedback highlights three key issues: a bug in the filter popover where reopening it displays stale search results instead of triggering a fresh search, a bug in the user list route where an empty roleId query parameter incorrectly filters by ID 0, and a corresponding update needed in the documentation example to prevent this empty-string parsing issue.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c452127e0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?