Skip to content

feat: Add filters for data table#695

Merged
aXenDeveloper merged 3 commits into
canaryfrom
feat/data_table_filters
Jun 14, 2026
Merged

feat: Add filters for data table#695
aXenDeveloper merged 3 commits into
canaryfrom
feat/data_table_filters

Conversation

@aXenDeveloper

Copy link
Copy Markdown
Owner

Improving Documentation

Description

What?

Why?

@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vitnode-docs Error Error Jun 14, 2026 4:17pm

@github-actions github-actions Bot added the 💡 Feature A new feature label Jun 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a faceted multi-select filtering feature to the DataTable component, allowing both static and async (server-side) filtering. It also adds role-based filtering for the admin users list, search support for the admin roles list, and updates the documentation and localization files accordingly. The review feedback highlights three key issues: a bug in the filter popover where reopening it displays stale search results instead of triggering a fresh search, a bug in the user list route where an empty roleId query parameter incorrectly filters by ID 0, and a corresponding update needed in the documentation example to prevent this empty-string parsing issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/vitnode/src/components/table/filters.tsx Outdated
Comment thread packages/vitnode/src/api/modules/admin/users/routes/list.route.ts
Comment thread apps/docs/content/docs/ui/data-table.mdx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c452127e0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/vitnode/src/components/table/filters.tsx
@aXenDeveloper aXenDeveloper merged commit aad6587 into canary Jun 14, 2026
2 of 4 checks passed
@aXenDeveloper aXenDeveloper deleted the feat/data_table_filters branch June 14, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💡 Feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant