feat: P002827-13 implement Drupal - #72
Open
rutgerrademaker wants to merge 6 commits into
Open
Conversation
rutgerrademaker
requested review from
CyberSecutor,
eescribanoc,
leonhelmus and
youwe-petervanderwal
July 7, 2026 13:16
rutgerrademaker
force-pushed
the
feature/add-drupal-support
branch
from
July 7, 2026 13:20
f49052f to
e4a78da
Compare
youwe-petervanderwal
requested changes
Jul 16, 2026
| - /^pdepend.xml$/ | ||
|
|
||
| yamllint.parse_constant: true | ||
| yamllint.parse_custom_tags: false |
Contributor
There was a problem hiding this comment.
Why is this removed, it is added for a reason, see PR #69
Contributor
Author
There was a problem hiding this comment.
Thanks for flagging, guess I made a mistake here, had no intentions to change things
Also leaving out the "magento" related changes, as we only target drupal support in this PR
cc @leonhelmus
…r-non-blocking-on-libraries feat: allow non-blocking security tests on libraries/bundles
rutgerrademaker
force-pushed
the
feature/add-drupal-support
branch
2 times, most recently
from
July 24, 2026 08:43
fabec2d to
69a9347
Compare
After finding out PHPCS was always passing in CI, it turned out that this is related to the <root> folder in CI being named . As was marked as excluded in phpcs.xml, PHPCS was always passing in CI. Grumphp seems to offer better support for only excluding the directory inside the <root> directory.
rutgerrademaker
force-pushed
the
feature/add-drupal-support
branch
from
July 24, 2026 11:54
69a9347 to
659a113
Compare
leonhelmus
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.