macOS: reveal comics in Finder without AppleScript - #576
Open
starlit-void wants to merge 2 commits into
Open
Conversation
"Open containing folder" on a comic drove Finder through osascript, which
sends an Apple Event and therefore trips the macOS automation consent
dialog ("YACReaderLibrary wants access to control Finder"). The prompt is
opaque to users, since neither Info.plist declares an
NSAppleEventsUsageDescription to explain the request, and denying it
leaves the menu action silently doing nothing.
Use `open -R <path>` instead. It reveals and selects the file in Finder
with the same result, but goes through Launch Services rather than Apple
Events, so no permission is required. This also matches how the rest of
the codebase shells out to `open`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Open containing folder" on a comic drove Finder through osascript, which sends an Apple Event and therefore trips the macOS automation consent dialog ("YACReaderLibrary wants access to control Finder"). The prompt is opaque to users, since neither Info.plist declares an NSAppleEventsUsageDescription to explain the request, and denying it leaves the menu action silently doing nothing.
Use
open -R <path>instead. It reveals and selects the file in Finder with the same result, but goes through Launch Services rather than Apple Events, so no permission is required. This also matches how the rest of the codebase shells out toopen.