Add check for functions ending in __premium_only - #1447
Open
ishitaj34 wants to merge 4 commits into
Open
Conversation
ishitaj34
requested review from
chriscct7,
davidperezgar,
ernilambar and
frantorres
as code owners
August 21, 2026 18:26
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ishitaj34
force-pushed
the
fix/issue-1443
branch
from
August 21, 2026 18:32
88f5c86 to
953af9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #1443
Adds a static check
Premium_Only_Function_Checkin thePlugin Repocategory to detect PHP function declarations whose names end with the__premium_onlysuffix.As a potential future enhancement, this check could be upgraded to a token-aware sniff to ensure occurrences of
__premium_onlyinside PHP comments, docblocks, or string literals are completely ignored.Why?
WordPress.org plugin directory guidelines do not allow code intended strictly for a paid/pro/premium version to be included in free plugin submissions. Detecting common naming conventions like
__premium_onlyhelps authors identify and relocate premium-only code before submitting plugins for review.How?
Abstract_File_Check.premium_only_function_founderror.Default_Check_Repository.Testing Instructions
AI Usage Disclosure
If AI tools were used, please describe how they were used:
Premium_Only_Function_Check, draft PHPUnit unit test cases, and verify WordPress coding standards compliance. Evaluated architectural trade-offs and manually verified all code, tests, and static analysis outputs.