CQL Heuristics Calculator#1620
Open
gonzalotguerrero wants to merge 29 commits into
Open
Conversation
…sion-replacement-v2
jgaleotti
requested changes
Jul 8, 2026
- Small refactorings to follow dev guidelines - Refactor parsing of Duration literals and reorganise packages - Unify distance calculation for strings - Refactor operation evaluator - Add javadoc for calculator and CassandraRow abstraction
- More refactorings in parser utils - Add missing docs in parser utils
jgaleotti
requested changes
Jul 9, 2026
…ent-v2 More CqlSession Replacements
- Use pattern for standard ISO - Improve CqlDurationLiteralParser and create unit tests class - Replace reflection with use of TemporalAmount
jgaleotti
requested changes
Jul 15, 2026
| } else if (op instanceof ContainsKeyOperation<?>) { | ||
| return evaluateContainsKey((ContainsKeyOperation<?>) op, candidateRow); | ||
| } else { | ||
| return FALSE_TRUTHNESS; |
Collaborator
There was a problem hiding this comment.
throw an exception for not supported evaluations
| private Truthness evaluateContains(ContainsOperation<?> op, CassandraRow candidateRow) { | ||
| Object rawCol = candidateRow.getValue(op.getColumnName()); | ||
| if (rawCol == null) { | ||
| return FALSE_TRUTHNESS; |
Collaborator
There was a problem hiding this comment.
this means that the column value for that column is null, or that the column is not defined?
Collaborator
Author
There was a problem hiding this comment.
It means the column is not defined for that specific row! I'll modify the code so that it's not ambiguous
Collaborator
There was a problem hiding this comment.
what if a null value is stored in the candidateRow, how can you disambiguate?
| Object rawCol = candidateRow.getValue(op.getColumnName()); | ||
| if (rawCol == null) { | ||
| return FALSE_TRUTHNESS; | ||
| } else if (!(rawCol instanceof Map<?, ?>)) { |
Collaborator
There was a problem hiding this comment.
could a contain key be evaluated on a column that is not a map?
Collaborator
Author
There was a problem hiding this comment.
According to the CQL documentation, that's not possible
Collaborator
Author
There was a problem hiding this comment.
I'll add an exception for this scenario!
|
|
||
| private Truthness evaluateContainsKey(ContainsKeyOperation<?> op, CassandraRow candidateRow) { | ||
| Object rawCol = candidateRow.getValue(op.getColumnName()); | ||
| if (rawCol == null) { |
Collaborator
There was a problem hiding this comment.
again, is this a valid value for candidateRow.getValue(String) ?
Collaborator
Author
There was a problem hiding this comment.
If the candidate row does not have that column defined, it could be possible
| Object rowValue = candidateRow.getValue(op.getColumnName()); | ||
| Object queryValue = op.getValue(); | ||
|
|
||
| if (rowValue == null && queryValue == null) { |
Collaborator
There was a problem hiding this comment.
Is NULL literal valid in CQL? I think it is not valid. Therefore, queryValue cannot have null as value, right?
Collaborator
Author
There was a problem hiding this comment.
You're right, it's not. I'll change the code so that only rowValue is considered!
| CqlDurationLiteral literalDurationValue = CqlDurationLiteralParser.parse((String) literalValue); | ||
|
|
||
| return TruthnessUtils.buildAndAggregationTruthness( | ||
| TruthnessUtils.getEqualityTruthness(months, literalDurationValue.months), |
Collaborator
There was a problem hiding this comment.
define a variable for each getEqualityTruthness to improve readability
|
|
||
| private Truthness evaluateEquals(Object a, Object b) { | ||
| if (a == null && b == null) { | ||
| return FALSE_TRUTHNESS; |
Collaborator
There was a problem hiding this comment.
again, check semantics of NULL==NULL
| } else if (a == null || b == null) { | ||
| return FALSE_TRUTHNESS_BETTER; | ||
| } else { | ||
| Truthness raw = compareByType(a, b, ComparisonType.EQUALS); |
Collaborator
Author
There was a problem hiding this comment.
It means it's the truthness instance before being scaled! I'll change the name
| if (t.isEmpty()) { | ||
| throw new IllegalArgumentException("Empty duration literal"); | ||
| } else { | ||
| boolean isNegative = t.startsWith("-"); |
Collaborator
There was a problem hiding this comment.
replace "-" with constant
| String upper = unsigned.toUpperCase(); | ||
| if (upper.endsWith(ISO_WEEK_SUFFIX)) { | ||
| return parseIso8601WeekPattern(upper); | ||
| } else if (upper.contains("-")) { |
jgaleotti
requested changes
Jul 21, 2026
| private Truthness evaluateContains(ContainsOperation<?> op, CassandraRow candidateRow) { | ||
| Object rawCol = candidateRow.getValue(op.getColumnName()); | ||
| if (rawCol == null) { | ||
| return FALSE_TRUTHNESS; |
Collaborator
There was a problem hiding this comment.
what if a null value is stored in the candidateRow, how can you disambiguate?
jgaleotti
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CassandraHeuristicsCalculator/CassandraOperationEvaluator to compute a distance heuristic for CQL WHERE clauses
Distance calculation for each operator/data type follows the spec from this document