fix(connect): premium flips on at connect time; upsell links reach the connect tab (#71 #72) - #74
Merged
Merged
Conversation
…e connect tab (#71 #72) + 2.4.1 store_cloud_credentials() now marks the API status active instead of only clearing the cache: its only caller is the connect flow, right after a successful token exchange, so the key is known-good and is_premium() should not wait for a lazy revalidation while the user is watching their freshly connected site do nothing. Dashboard widget deep link used a #tab-cloud hash the settings page ignores (it only reads ?tab=cloud); the Statistics upsell sent people off-site to /pricing instead of the in-admin connect CTA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71. Closes #72. Ships as 2.4.1 (version bumps included).
store_cloud_credentials()now callsset_api_status_cache('active')instead of only clearing: its sole caller is the connect flow immediately after a successful exchange, so the key is known-good andis_premium()gates (JS verification token injection, violation reporter) turn on instantly. The option-update hook fires duringupdate_options_raw, so the set lands after the hook's clear and survives.#tab-cloudhash →&tab=cloud(the only form tab resolution reads).84/84 tests pass,
php -lclean. After merge:bin/release-all.sh 2.4.1 --publishfrom main.