Fix channel drag-and-drop reliability and crosshair highlight - #1654
Open
SkyJoshua wants to merge 1 commit into
Open
Fix channel drag-and-drop reliability and crosshair highlight#1654SkyJoshua wants to merge 1 commit into
SkyJoshua wants to merge 1 commit into
Conversation
draggable was bound to a bare bool, which Blazor renders in a way the browser doesn't recognize as a valid draggable state. Also fixes the window-split crosshair not highlighting during a channel drag by watching real dragover events instead of the drag event's coordinates, which don't track the cursor.
SigmaTel71
approved these changes
Aug 2, 2026
SigmaTel71
left a comment
Member
There was a problem hiding this comment.
I think I am okay with the code.
I'm still thinking why TypeScript compilation artifacts are in the repo (.razor.js and .razor.js.map files) but it is out of scope of this PR. That's something I'll ask SpikeViper later in the chat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
draggableon channel/favorite rows was bound directly to a barebool. Blazor renders that using its "boolean HTML attribute" convention, which isn't a value the browser recognizes fordraggable(a true/false enumerated attribute, not a real toggle attribute) — so the row often just wasn't draggable at all. Now renders an explicit"true"/"false"string.@ondragevent don't track the actual cursor position for native drags, so the existing scanner never found the real hovered target. Added a nativedragoverlistener (capture phase, since the crosshair's own handler stops propagation) that tracks the real hovered element instead.You're welcome @jadennaut :P
Test plan