Let a planet's vanity URL double as an invite link - #1650
Open
SkyJoshua wants to merge 1 commit into
Open
Conversation
Adds a toggle in the Invites settings (only shown once Invites Enabled is
on) that lets /i/{vanity} work as a standing, permanent invite alongside
regular invite codes.
Deploying valour with
|
| Latest commit: |
4e1d0a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6429050.valour.pages.dev |
| Branch Preview URL: | https://feat-vanity-invite-link.valour.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Use Vanity URL as Invite" toggle to a planet's Invites settings, only shown once Invites Enabled is on. When turned on,
/i/{vanity}(e.g./i/valourcentral) works as a standing, permanent invite link alongside a planet's regular randomly-generated invite codes — a memorable name instead of a random code, without needing to manage a separate invite entry.Changes
Planet.VanityInviteEnabled(bool), plumbed through the Database/Shared/Sdk/Server models and mapper, with a migration/i/{code}screen + join flow) falls back to checking a planet's vanity name when the code doesn't match a real invite — no client routing changes needed, since the existing invite page and deep-link parsing are already code-agnosticTest plan
/i/{vanity}resolves and lets someone join/i/{vanity}stop workingImages
Invites Disabled
Invites Enabled with VanityURL set
Invites Enabled without VanityURL set
Vanity Invite Enabled
Vanity Invite in Invite Links