fix: Filtered SSIDs persist in time graph legend

[mdrkrg]

Summary

• Adds two failing unit tests that expose a bug where filtered-out SSIDs persist in the time graph legend after enabling a filter directly from the time graph screen.
• These tests are first committed as TDD RED before the fix.

What does this implement/fix?

This PR adds two test cases in DataManagerTest.kt that fail:

• newSeriesShouldNotIncludeActiveCacheEntriesNotInCurrentWiFiDetails -- verifies that newSeries() excludes cached entries that do not match the applied filter predicate.
• adjustDataShouldNotAppendToStaleCacheEntriesNotInCurrentDetails -- verifies that adjustData() does not append floor-level data points or increment TimeGraphCache counters for entries that do not match the predicate.

The bug: when a user navigates directly to the time graph and enables an SSID filter, DataManager.newSeries() unconditionally merges timeGraphCache.active() entries into the return set. Since removeSeries() only removes series not in this set, filtered-out SSIDs remain visible for up to MAX_NOT_SEEN_COUNT (20) scans.

Does this close any issues?

None.

How was this tested?

• Devices / OS (e.g. Android 13 emulator, Pixel 6): Android 15 and Unit tests
• Platform / Build variant (e.g. debug/release): debug
• Toolchain / Gradle / SDK version(s): Kotlin 2.3.20, AGP 9.1.1, Gradle 9.4.1
• Steps to reproduce / test (provide exact steps so reviewers can verify): Time Graph -> Apply Filter -> See the SSIDs that should be filtered out are still in the legend.

Checklist (required before marking ready)

• I added or updated unit tests (see app/src/test/)
• I followed the project's coding style (ktlint) and formatting
• I ran lint and addressed or documented any warnings
• CI checks pass (unit tests, coverage, lint)
• No sensitive data, keys, or secrets are included

AI Assistance

• AI tools were used (Copilot, ChatGPT, Claude, etc.) — please add the “AI assistance used” label.
• No AI tools were used

Additional context

None.

Reviewer notes

None.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (dcdd006) to head (ec1d67f).

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #610   +/-   ##
=========================================
  Coverage     97.83%   97.83%           
  Complexity      975      975           
=========================================
  Files           121      121           
  Lines          2581     2585    +4     
  Branches        211      211           
=========================================
+ Hits           2525     2529    +4     
  Misses           19       19           
  Partials         37       37           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR fixes a bug where SSIDs filtered out via the time graph filter dialog persisted in the legend for up to 20 scans. It threads the filter Predicate from TimeGraphView into DataManager.addSeriesData(), so both adjustData() and newSeries() exclude filtered-out entries from differenceSeries() and timeGraphCache.active(). New unit tests cover the filtered cache/difference paths.

Changes:

• Pass Predicate from TimeGraphView.update() into DataManager.addSeriesData().
• Apply the predicate inside adjustData() (difference series) and newSeries() (active cache) in DataManager.
• Update existing tests for the new signatures and add two new tests covering filtered-out stale entries.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
app/src/main/kotlin/com/vrem/wifianalyzer/wifi/timegraph/TimeGraphView.kt	Pass predicate to DataManager.addSeriesData().
app/src/main/kotlin/com/vrem/wifianalyzer/wifi/timegraph/DataManager.kt	Accept predicate; filter difference series and cached active entries by it.
app/src/test/kotlin/com/vrem/wifianalyzer/wifi/timegraph/TimeGraphViewTest.kt	Update mocks/verifications for new addSeriesData signature.
app/src/test/kotlin/com/vrem/wifianalyzer/wifi/timegraph/DataManagerTest.kt	Update existing tests and add two TDD tests for filtered cache/difference behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[VREMSoftwareDevelopment]

After reviewing the new behavior and testing it in real-world use, this PR will be reverted, for the reasons below:

• The time graph is a rolling history — it already ages a network out of the window over ~20 scans once it stops being seen.
• A filter applies at a point in time: it should change what's recorded from then on, not erase history that's already there.
• It also breaks switching filters — changing the filter drops the watched network's history, since the series gets evicted from the cache.
• Immediate filtering is correct for a snapshot, and the channel graph already does that (stateless, redrawn every scan). That's where it belongs.
• Reverting the predicate threading in DataManager so the time graph keeps history.

Thanks for the PR.