Support OAuth client_secret_basic#1448
Open
MisterJimson wants to merge 2 commits into
Open
Conversation
MisterJimson
marked this pull request as ready for review
July 21, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client_secret_postandclient_secret_basicin the OAuth client API and formclient_secret_postas the default for existing clientsCloses #1447
Root cause
The low-level token helper already supported HTTP Basic authentication, but the OAuth client model did not persist that choice and its callers did not pass it through. As a result, confidential clients always sent their credentials in the request body.
Validation
bun run format:checkbun run lintbun run typecheck(43 packages)bun run test(37 tasks)Draft notes