京王バス・東急バスのGTFS対応を追加#1603
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
リリースブランチ
masterに開発ブランチdevの変更を取り込みます。京王バス(京王電鉄バス)と東急バスの GTFS / ODPT 対応の追加、および京王バス GTFS ダウンロードの 404 修正を含みます。変更の種類
変更内容
company_cd=254の会社エントリ、keio:プレフィックスの会社コードマッピング、data/1!companies.csvへの追加)(京王バスのGTFSフィードを追加 #1601)dateセレクタが必須のため?date=currentを付与して常に現行ダイヤを取得し、acl:consumerKeyのクエリ結合バグ(既存クエリがある場合は&で連結)を修正。あわせて 1 フィードのダウンロード失敗(HTTP エラー・パニック/キャンセル)を非致命化して他フィードのインポートを継続、失敗時の部分展開ディレクトリ削除、reqwest エラーからのトークン付き URL 除去 (京王バスGTFSのダウンロード404を修正 #1602)tokyu_ota/tokyu_shinagawa/tokyu_meguro)に加え、ODPT JSON(BusroutePattern / BusstopPole / BusTimetable)による実ダイヤ取り込みを追加。company_cd=255の会社エントリ(東急バス)を追加 (東急バスをGTFS・ODPT JSONから統合 #1600)テスト
cargo fmt --all -- --checkが通ることcargo clippy -- -D warningsが通ることcargo test(SQLX_OFFLINE=true)が通ることいずれも取り込み元の #1600 / #1601 / #1602 で実行済み・CI green です(本 PR はそれらのマージ済み変更の
masterへの反映で、コード差分は同一)。関連Issue
スクリーンショット(任意)