Skip to content

PR_26179_CHARLIE_031-sprites-picker-zoom#267

Merged
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_031-sprites-picker-zoom
Jun 28, 2026
Merged

PR_26179_CHARLIE_031-sprites-picker-zoom#267
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_031-sprites-picker-zoom

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Implement Picker for existing painted draft pixels.
  • Add display-only zoom controls for 100%, 200%, and 400%.
  • Keep Move deferred and preserve no persistence/no DB/API/schema scope.

Validation

  • PASS: node --check assets/toolbox/sprites/js/index.js
  • PASS: node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs
  • PASS: git diff --check for touched runtime/test files
  • PASS: targeted Sprite Creator Playwright shell test

Artifact

  • dev/workspace/zip/PR_26179_CHARLIE_031-sprites-picker-zoom_delta.zip

@ToolboxAid
ToolboxAid marked this pull request as ready for review June 28, 2026 20:16
@ToolboxAid
ToolboxAid changed the base branch from PR_26179_CHARLIE_030-sprites-undo-redo to main June 28, 2026 20:16
@ToolboxAid
ToolboxAid merged commit cc4d22d into main Jun 28, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5803b0494

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}

.sprite-canvas-shell[data-sprites-zoom-level="2"] .sprite-canvas-grid {
width: min(720px, 160%)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Match canvas zoom to the selected percentage

When the center panel is wide enough for the normal grid to reach its 520px cap, the 200% control only grows the grid to 720px (about 138%), and the adjacent 400% rule caps at 960px (about 185%), even though the UI/status reports 200% and 400%. This makes the new zoom controls visibly under-scale the canvas in the common desktop layout; tie these widths to the base canvas size or use a real scale so the displayed zoom matches the selected percentage.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant