|
1 | | -diff --git a/.gitignore b/.gitignore |
2 | | -index dcf729395..17158ebff 100644 |
3 | | ---- a/.gitignore |
4 | | -+++ b/.gitignore |
5 | | -@@ -13,10 +13,12 @@ |
6 | | - # Ignore the NEXT_COMMAND.txt file |
7 | | - NEXT_COMMAND.txt |
| 1 | +PR_26174_ALFA_000-projectinstructions-archive-ignore review diff |
8 | 2 |
|
9 | | --# Ignore the tests results and temporary files |
10 | | -+# Ignore generated dependency, test result, and temporary files |
11 | | - node_modules/ |
12 | | - tests/results/ |
13 | | -+tests/results/** |
14 | | - tmp/test-results/ |
15 | | -+tmp/test-results/** |
16 | | - tmp/ |
17 | | - scripts/untracked/ |
18 | | - projects/ |
19 | | -diff --git a/docs_build/dev/reports/PR_26172_CHARLIE_002-test-results-artifact-cleanup.md b/docs_build/dev/reports/PR_26172_CHARLIE_002-test-results-artifact-cleanup.md |
20 | | -new file mode 100644 |
21 | | -index 000000000..17898495f |
22 | | ---- /dev/null |
23 | | -+++ b/docs_build/dev/reports/PR_26172_CHARLIE_002-test-results-artifact-cleanup.md |
24 | | -@@ -0,0 +1,129 @@ |
25 | | -+# PR_26172_CHARLIE_002 Test Results Artifact Cleanup |
26 | | -+ |
27 | | -+## Scope |
28 | | -+ |
29 | | -+Clean up generated test result artifacts under `tests/results/` after the Charlie repository compliance audit identified that path as a high-priority cleanup candidate. |
30 | | -+ |
31 | | -+Source audit: |
32 | | -+ |
33 | | -+- `docs_build/dev/reports/PR_26172_CHARLIE_001-repository-compliance-audit.md` |
34 | | -+ |
35 | | -+This PR does not modify runtime source and does not move unrelated tests. |
36 | | -+ |
37 | | -+## Team Ownership |
38 | | -+ |
39 | | -+- TEAM token: CHARLIE |
40 | | -+- Ownership classification: governance / repository hygiene / diagnostics |
41 | | -+- TEAM ownership result: PASS |
42 | | -+ |
43 | | -+## Branch Validation |
44 | | -+ |
45 | | -+| Requirement | Status | Evidence | |
46 | | -+| --- | --- | --- | |
47 | | -+| Started from latest main | PASS | `main` was pulled before branch creation; source commit `f2b50ac9d79256df3a7716ac4eff21f3a4303bb3`. | |
48 | | -+| Worktree clean before branch | PASS | `git status --short` returned no output before branch creation. | |
49 | | -+| Local/origin sync before branch | PASS | `git rev-list --left-right --count HEAD...origin/main` returned `0 0`. | |
50 | | -+| PR branch created from main | PASS | Branch `pr/26172-CHARLIE-002-test-results-artifact-cleanup` was created from latest `main`. | |
51 | | -+ |
52 | | -+## Files Reviewed |
53 | | -+ |
54 | | -+`git ls-files tests/results` returned no tracked files. |
55 | | -+ |
56 | | -+The local ignored `tests/results/` folder contained generated Playwright/report output: |
57 | | -+ |
58 | | -+- `tests/results/artifacts/.last-run.json` |
59 | | -+- `tests/results/artifacts/tools-MidiStudioV2-MIDI-St-3c5a9-multi-song-manifest-payload-playwright/trace.zip` |
60 | | -+- `tests/results/artifacts/tools-MidiStudioV2-MIDI-St-752e4-on-and-timeline-scroll-sync-playwright/trace.zip` |
61 | | -+- `tests/results/artifacts/tools-MidiStudioV2-MIDI-St-c50c5-m-Tool-Mode-standalone-save-playwright/trace.zip` |
62 | | -+- `tests/results/playwright-results.json` |
63 | | -+- `tests/results/report/data/09daf0cfe8750af5e9e5bb22161367f97296f4fd.zip` |
64 | | -+- `tests/results/report/data/a9ba8bc1c6a629055b981a6f385fa4de3e42a79d.zip` |
65 | | -+- `tests/results/report/data/b1dc1da730cbd5e9adc334a6f385fa4de3e42a79d.zip` |
66 | | -+- `tests/results/report/data/c150573559f5367f4ec5724abb7a55798abcdff9.zip` |
67 | | -+- `tests/results/report/index.html` |
68 | | -+- `tests/results/report/trace/assets/codeMirrorModule-DS0FLvoc.js` |
69 | | -+- `tests/results/report/trace/assets/defaultSettingsView-GTWI-W_B.js` |
70 | | -+- `tests/results/report/trace/codeMirrorModule.DYBRYzYX.css` |
71 | | -+- `tests/results/report/trace/codicon.DCmgc-ay.ttf` |
72 | | -+- `tests/results/report/trace/defaultSettingsView.B4dS75f0.css` |
73 | | -+- `tests/results/report/trace/index.C5466mMT.js` |
74 | | -+- `tests/results/report/trace/index.CzXZzn5A.css` |
75 | | -+- `tests/results/report/trace/index.html` |
76 | | -+- `tests/results/report/trace/manifest.webmanifest` |
77 | | -+- `tests/results/report/trace/playwright-logo.svg` |
78 | | -+- `tests/results/report/trace/snapshot.html` |
79 | | -+- `tests/results/report/trace/sw.bundle.js` |
80 | | -+- `tests/results/report/trace/uiMode.Btcz36p_.css` |
81 | | -+- `tests/results/report/trace/uiMode.Vipi55dB.js` |
82 | | -+- `tests/results/report/trace/uiMode.html` |
83 | | -+- `tests/results/report/trace/xtermModule.DYP7pi_n.css` |
84 | | -+ |
85 | | -+## Files Removed Or Retained |
86 | | -+ |
87 | | -+| Category | Status | Notes | |
88 | | -+| --- | --- | --- | |
89 | | -+| Tracked files under `tests/results/` | None removed | No tracked files existed under `tests/results/`. | |
90 | | -+| Local ignored generated artifacts under `tests/results/` | Removed from workspace | Removed only after verifying the resolved target path was inside the repository. | |
91 | | -+| Active test source | Retained | No active test source was found under `tests/results/`. | |
92 | | -+| Fixture or baseline data | Retained | No committed fixture or baseline dependency was found under `tests/results/`. | |
93 | | -+ |
94 | | -+## Reference And Dependency Check |
95 | | -+ |
96 | | -+| Check | Status | Evidence | |
97 | | -+| --- | --- | --- | |
98 | | -+| Active tracked files under `tests/results/` | PASS | `git ls-files tests/results` returned no output. | |
99 | | -+| Tracked ignored files under `tests/results/` | PASS | `git ls-files -c -i --exclude-standard tests/results` returned no output. | |
100 | | -+| Ignored local generated files under `tests/results/` | PASS | `git ls-files -o -i --exclude-standard tests/results` listed only Playwright/report artifacts. | |
101 | | -+| Active config uses `tmp/test-results/` | PASS | `playwright.config.cjs` writes output, artifacts, HTML report, and JSON report under `tmp/test-results/`. | |
102 | | -+| Active references to `tests/results/` | PASS | Active config/test/docs search returned no required source or fixture dependency. | |
103 | | -+| Historical references retained | PASS | References in `archive/` and historical `docs_build/dev/reports/` were not modified. | |
104 | | -+ |
105 | | -+## Ignore Rule Changes |
106 | | -+ |
107 | | -+Updated `.gitignore` to make generated test-output protection explicit: |
108 | | -+ |
109 | | -+- Kept `tests/results/`. |
110 | | -+- Added `tests/results/**`. |
111 | | -+- Kept `tmp/test-results/`. |
112 | | -+- Added `tmp/test-results/**`. |
113 | | -+- Confirmed `tmp/` remains ignored. |
114 | | -+ |
115 | | -+Ignore probe: |
116 | | -+ |
117 | | -+- `git check-ignore -v tests/results/probe.txt` resolves to `.gitignore`. |
118 | | -+- `git check-ignore -v tmp/test-results/probe.txt` resolves to `.gitignore`. |
119 | | -+ |
120 | | -+## Requirement Checklist |
121 | | -+ |
122 | | -+| Requirement | Status | Evidence | |
123 | | -+| --- | --- | --- | |
124 | | -+| Confirm Project Instructions were reviewed | PASS | Read `docs_build/dev/ProjectInstructions/README.txt`, `PROJECT_INSTRUCTIONS.md`, branch/workflow governance, team ownership, and artifact/reporting rules. | |
125 | | -+| Use PR_26172_CHARLIE_001 findings | PASS | This cleanup is based on the P0 `tests/results/` finding. | |
126 | | -+| Review `tests/results/` | PASS | Reviewed tracked, ignored, and local generated contents. | |
127 | | -+| Confirm generated artifacts, not active source | PASS | Files were Playwright JSON, HTML report, trace assets, and zipped trace/report data. | |
128 | | -+| Search references to `tests/results/` files | PASS | No active source/fixture dependency found; historical references retained. | |
129 | | -+| Remove tracked generated artifacts if safe | PASS | No tracked generated artifacts existed to remove. | |
130 | | -+| Add/update ignore rules | PASS | `.gitignore` now explicitly includes `tests/results/**` and `tmp/test-results/**`. | |
131 | | -+| Do not remove active test source | PASS | No active test source removed. | |
132 | | -+| Do not modify runtime source | PASS | No runtime source changed. | |
133 | | -+| Do not move unrelated tests | PASS | No test files were moved. | |
134 | | -+| Stop gate not triggered | PASS | No `tests/results/` file was required as active source, fixture data, or committed baseline data. | |
135 | | -+| Create required reports | PASS | `docs_build/dev/reports/codex_review.diff` and `docs_build/dev/reports/codex_changed_files.txt` exist. | |
136 | | -+| Create ZIP artifact | PASS | `tmp/PR_26172_CHARLIE_002-test-results-artifact-cleanup_delta.zip` exists. | |
137 | | -+ |
138 | | -+## Validation Lane Report |
139 | | -+ |
140 | | -+- `git diff --check`: PASS. |
141 | | -+- Cleanup limited to generated artifacts under `tests/results/`: PASS. |
142 | | -+- Ignore rule prevents recommit: PASS. |
143 | | -+- Runtime source files changed: PASS, no runtime source files changed. |
144 | | -+- Required reports exist: PASS. |
145 | | -+- ZIP artifact exists: PASS. |
146 | | -+- Playwright: SKIP, ignore/report-only cleanup with no active test or runtime source changes. |
147 | | -+- Samples: SKIP, no sample files changed. |
148 | | -+ |
149 | | -+## Manual Validation Notes |
150 | | -+ |
151 | | -+- The local ignored `tests/results/` directory was deleted from the workspace only after path verification showed it was inside the repository root. |
152 | | -+- Repository history already contains `docs_build/dev/reports/docs_archive_test_output_cleanup_report.md`, which documents the prior migration of generated test output from `tests/results/` to `tmp/test-results/`. |
153 | | -+- This PR preserves historical report/archive references and only hardens the active ignore rule. |
154 | | -diff --git a/docs_build/dev/reports/codex_changed_files.txt b/docs_build/dev/reports/codex_changed_files.txt |
155 | | -index d2e0439c1..74a4a12b1 100644 |
156 | | ---- a/docs_build/dev/reports/codex_changed_files.txt |
157 | | -+++ b/docs_build/dev/reports/codex_changed_files.txt |
158 | | -@@ -1,3 +1,4 @@ |
159 | | --docs_build/dev/reports/PR_26172_CHARLIE_001-repository-compliance-audit.md |
160 | | -+.gitignore |
161 | | -+docs_build/dev/reports/PR_26172_CHARLIE_002-test-results-artifact-cleanup.md |
162 | | - docs_build/dev/reports/codex_changed_files.txt |
163 | | - docs_build/dev/reports/codex_review.diff |
| 3 | +.gitignore |
| 4 | +@@ |
| 5 | + # Game Foundry Studio project files |
| 6 | + assets/*.gfsp |
| 7 | ++docs_build/dev/ProjectInstructions.zip |
0 commit comments