Skip to content

Commit dd72e83

Browse files
ToolboxAidToolboxAid
authored
PR_26172_CHARLIE_002-test-results-artifact-cleanup
Merge PR_26172_CHARLIE_002-test-results-artifact-cleanup
2 parents f2b50ac + 5f25824 commit dd72e83

4 files changed

Lines changed: 255 additions & 214 deletions

File tree

‎.gitignore‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,12 @@
1313
# Ignore the NEXT_COMMAND.txt file
1414
NEXT_COMMAND.txt
1515

16-
# Ignore the tests results and temporary files
16+
# Ignore generated dependency, test result, and temporary files
1717
node_modules/
1818
tests/results/
19+
tests/results/**
1920
tmp/test-results/
21+
tmp/test-results/**
2022
tmp/
2123
scripts/untracked/
2224
projects/

‎docs_build/dev/reports/PR_26172_CHARLIE_002-test-results-artifact-cleanup.md‎

Lines changed: 129 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,129 @@
1+
# PR_26172_CHARLIE_002 Test Results Artifact Cleanup
2+
3+
## Scope
4+
5+
Clean up generated test result artifacts under `tests/results/` after the Charlie repository compliance audit identified that path as a high-priority cleanup candidate.
6+
7+
Source audit:
8+
9+
- `docs_build/dev/reports/PR_26172_CHARLIE_001-repository-compliance-audit.md`
10+
11+
This PR does not modify runtime source and does not move unrelated tests.
12+
13+
## Team Ownership
14+
15+
- TEAM token: CHARLIE
16+
- Ownership classification: governance / repository hygiene / diagnostics
17+
- TEAM ownership result: PASS
18+
19+
## Branch Validation
20+
21+
| Requirement | Status | Evidence |
22+
| --- | --- | --- |
23+
| Started from latest main | PASS | `main` was pulled before branch creation; source commit `f2b50ac9d79256df3a7716ac4eff21f3a4303bb3`. |
24+
| Worktree clean before branch | PASS | `git status --short` returned no output before branch creation. |
25+
| Local/origin sync before branch | PASS | `git rev-list --left-right --count HEAD...origin/main` returned `0 0`. |
26+
| PR branch created from main | PASS | Branch `pr/26172-CHARLIE-002-test-results-artifact-cleanup` was created from latest `main`. |
27+
28+
## Files Reviewed
29+
30+
`git ls-files tests/results` returned no tracked files.
31+
32+
The local ignored `tests/results/` folder contained generated Playwright/report output:
33+
34+
- `tests/results/artifacts/.last-run.json`
35+
- `tests/results/artifacts/tools-MidiStudioV2-MIDI-St-3c5a9-multi-song-manifest-payload-playwright/trace.zip`
36+
- `tests/results/artifacts/tools-MidiStudioV2-MIDI-St-752e4-on-and-timeline-scroll-sync-playwright/trace.zip`
37+
- `tests/results/artifacts/tools-MidiStudioV2-MIDI-St-c50c5-m-Tool-Mode-standalone-save-playwright/trace.zip`
38+
- `tests/results/playwright-results.json`
39+
- `tests/results/report/data/09daf0cfe8750af5e9e5bb22161367f97296f4fd.zip`
40+
- `tests/results/report/data/a9ba8bc1c6a629055b981a6f385fa4de3e42a79d.zip`
41+
- `tests/results/report/data/b1dc1da730cbd5e9adc334a6f385fa4de3e42a79d.zip`
42+
- `tests/results/report/data/c150573559f5367f4ec5724abb7a55798abcdff9.zip`
43+
- `tests/results/report/index.html`
44+
- `tests/results/report/trace/assets/codeMirrorModule-DS0FLvoc.js`
45+
- `tests/results/report/trace/assets/defaultSettingsView-GTWI-W_B.js`
46+
- `tests/results/report/trace/codeMirrorModule.DYBRYzYX.css`
47+
- `tests/results/report/trace/codicon.DCmgc-ay.ttf`
48+
- `tests/results/report/trace/defaultSettingsView.B4dS75f0.css`
49+
- `tests/results/report/trace/index.C5466mMT.js`
50+
- `tests/results/report/trace/index.CzXZzn5A.css`
51+
- `tests/results/report/trace/index.html`
52+
- `tests/results/report/trace/manifest.webmanifest`
53+
- `tests/results/report/trace/playwright-logo.svg`
54+
- `tests/results/report/trace/snapshot.html`
55+
- `tests/results/report/trace/sw.bundle.js`
56+
- `tests/results/report/trace/uiMode.Btcz36p_.css`
57+
- `tests/results/report/trace/uiMode.Vipi55dB.js`
58+
- `tests/results/report/trace/uiMode.html`
59+
- `tests/results/report/trace/xtermModule.DYP7pi_n.css`
60+
61+
## Files Removed Or Retained
62+
63+
| Category | Status | Notes |
64+
| --- | --- | --- |
65+
| Tracked files under `tests/results/` | None removed | No tracked files existed under `tests/results/`. |
66+
| Local ignored generated artifacts under `tests/results/` | Removed from workspace | Removed only after verifying the resolved target path was inside the repository. |
67+
| Active test source | Retained | No active test source was found under `tests/results/`. |
68+
| Fixture or baseline data | Retained | No committed fixture or baseline dependency was found under `tests/results/`. |
69+
70+
## Reference And Dependency Check
71+
72+
| Check | Status | Evidence |
73+
| --- | --- | --- |
74+
| Active tracked files under `tests/results/` | PASS | `git ls-files tests/results` returned no output. |
75+
| Tracked ignored files under `tests/results/` | PASS | `git ls-files -c -i --exclude-standard tests/results` returned no output. |
76+
| Ignored local generated files under `tests/results/` | PASS | `git ls-files -o -i --exclude-standard tests/results` listed only Playwright/report artifacts. |
77+
| Active config uses `tmp/test-results/` | PASS | `playwright.config.cjs` writes output, artifacts, HTML report, and JSON report under `tmp/test-results/`. |
78+
| Active references to `tests/results/` | PASS | Active config/test/docs search returned no required source or fixture dependency. |
79+
| Historical references retained | PASS | References in `archive/` and historical `docs_build/dev/reports/` were not modified. |
80+
81+
## Ignore Rule Changes
82+
83+
Updated `.gitignore` to make generated test-output protection explicit:
84+
85+
- Kept `tests/results/`.
86+
- Added `tests/results/**`.
87+
- Kept `tmp/test-results/`.
88+
- Added `tmp/test-results/**`.
89+
- Confirmed `tmp/` remains ignored.
90+
91+
Ignore probe:
92+
93+
- `git check-ignore -v tests/results/probe.txt` resolves to `.gitignore`.
94+
- `git check-ignore -v tmp/test-results/probe.txt` resolves to `.gitignore`.
95+
96+
## Requirement Checklist
97+
98+
| Requirement | Status | Evidence |
99+
| --- | --- | --- |
100+
| Confirm Project Instructions were reviewed | PASS | Read `docs_build/dev/ProjectInstructions/README.txt`, `PROJECT_INSTRUCTIONS.md`, branch/workflow governance, team ownership, and artifact/reporting rules. |
101+
| Use PR_26172_CHARLIE_001 findings | PASS | This cleanup is based on the P0 `tests/results/` finding. |
102+
| Review `tests/results/` | PASS | Reviewed tracked, ignored, and local generated contents. |
103+
| Confirm generated artifacts, not active source | PASS | Files were Playwright JSON, HTML report, trace assets, and zipped trace/report data. |
104+
| Search references to `tests/results/` files | PASS | No active source/fixture dependency found; historical references retained. |
105+
| Remove tracked generated artifacts if safe | PASS | No tracked generated artifacts existed to remove. |
106+
| Add/update ignore rules | PASS | `.gitignore` now explicitly includes `tests/results/**` and `tmp/test-results/**`. |
107+
| Do not remove active test source | PASS | No active test source removed. |
108+
| Do not modify runtime source | PASS | No runtime source changed. |
109+
| Do not move unrelated tests | PASS | No test files were moved. |
110+
| Stop gate not triggered | PASS | No `tests/results/` file was required as active source, fixture data, or committed baseline data. |
111+
| Create required reports | PASS | `docs_build/dev/reports/codex_review.diff` and `docs_build/dev/reports/codex_changed_files.txt` exist. |
112+
| Create ZIP artifact | PASS | `tmp/PR_26172_CHARLIE_002-test-results-artifact-cleanup_delta.zip` exists. |
113+
114+
## Validation Lane Report
115+
116+
- `git diff --check`: PASS.
117+
- Cleanup limited to generated artifacts under `tests/results/`: PASS.
118+
- Ignore rule prevents recommit: PASS.
119+
- Runtime source files changed: PASS, no runtime source files changed.
120+
- Required reports exist: PASS.
121+
- ZIP artifact exists: PASS.
122+
- Playwright: SKIP, ignore/report-only cleanup with no active test or runtime source changes.
123+
- Samples: SKIP, no sample files changed.
124+
125+
## Manual Validation Notes
126+
127+
- The local ignored `tests/results/` directory was deleted from the workspace only after path verification showed it was inside the repository root.
128+
- Repository history already contains `docs_build/dev/reports/docs_archive_test_output_cleanup_report.md`, which documents the prior migration of generated test output from `tests/results/` to `tmp/test-results/`.
129+
- This PR preserves historical report/archive references and only hardens the active ignore rule.

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1-
docs_build/dev/reports/PR_26172_CHARLIE_001-repository-compliance-audit.md
1+
.gitignore
2+
docs_build/dev/reports/PR_26172_CHARLIE_002-test-results-artifact-cleanup.md
23
docs_build/dev/reports/codex_changed_files.txt
34
docs_build/dev/reports/codex_review.diff

0 commit comments

Comments
 (0)