Skip to content

Commit b42248d

Browse files
committed
PR_26174_ALFA_016-active-game-indicator-polish
1 parent 505fdc3 commit b42248d

9 files changed

Lines changed: 102 additions & 765 deletions

assets/theme-v2/css/tables.css

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,7 @@ td {
116116
}
117117

118118
.data-table [data-game-active-cell="true"] {
119-
background: color-mix(in srgb, var(--gold) 14%, var(--panel))
120-
}
121-
122-
.data-table [data-game-active-cell="true"] {
119+
box-shadow: inset var(--space-3) 0 0 var(--gold);
123120
border-bottom-color: var(--gold-border-muted)
124121
}
125122

docs_build/dev/reports/PR_26174_ALFA_016-game-hub-row-edit-add-selected-state-manual-validation-notes.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
Manual Validation Notes
22

3-
PASS - Confirmed active-game selected styling is on the Game table cell/button, not the Actions edit button.
3+
PASS - Confirmed active-game selected styling is a thin Game-cell indicator, not a filled row background.
4+
PASS - Confirmed active game uses the same background color as non-active game cells.
5+
PASS - Confirmed active Game and Edit buttons do not use selected button styling.
46
PASS - Confirmed Edit remains a plain action until it opens an inline edit row.
57
PASS - Confirmed inline edit row shows Game, Purpose, Status, Owner, Actions columns with Save and Cancel.
68
PASS - Confirmed Game textbox is visible during edit and read-only because no rename API exists in the current Game Hub contract.
79
PASS - Confirmed Add Game row appears under the game table and expands to Game, Purpose, Status, Owner, Actions with Save and Cancel.
810
PASS - Confirmed add and edit saves use the existing repository API/service methods.
911
PASS - Confirmed Source Idea and Readiness Output child rows remain under expanded game parent rows.
1012
PASS - Confirmed guest users can browse/select games but cannot add or edit.
11-

docs_build/dev/reports/PR_26174_ALFA_016-game-hub-row-edit-add-selected-state-requirement-checklist.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
Requirement Checklist: PASS
22

3-
PASS - Selected state now appears on the Game button/cell for the active game.
3+
PASS - Selected state now appears as a thin indicator on the Game cell for the active game.
4+
PASS - Active game does not use a filled row background.
5+
PASS - Active game does not use a different background color.
6+
PASS - Active Game button does not use selected button styling.
47
PASS - Edit button does not look selected while a row is merely active.
58
PASS - Add Game button/row appears under the game table.
69
PASS - Add row includes Game textbox, Purpose dropdown, and Status dropdown.
@@ -12,4 +15,3 @@ PASS - Readiness Output child rows are preserved.
1215
PASS - table_first_ui.md and the Idea Board table-first add-row/edit-row pattern were followed.
1316
PASS - No browser-owned product data was introduced.
1417
PASS - No silent fallbacks were introduced.
15-

docs_build/dev/reports/PR_26174_ALFA_016-game-hub-row-edit-add-selected-state-validation-lane.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,5 @@ Result: PASS - 7 passed.
77
2. npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"
88
Result: PASS - 1 passed.
99

10-
3. git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs
10+
3. git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs
1111
Result: PASS.
12-

docs_build/dev/reports/PR_26174_ALFA_016-game-hub-row-edit-add-selected-state.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ Move Game Hub add/edit behavior into the game table and correct selected-state s
66

77
## Summary
88

9-
- Moved the active-game selected state from the Actions edit button to the Game column cell/button.
9+
- Moved the active-game indicator from the Actions edit button to a thin Game-cell indicator.
10+
- Removed filled active-game background styling and selected-button appearance.
1011
- Kept Edit as a plain row action and rendered Save/Cancel only while a row is editing.
1112
- Added a bottom Add Game row that expands into Game, Purpose, and Status fields with Save/Cancel actions.
1213
- Removed the old sidebar add-game form while preserving the existing API/service contract.
@@ -17,5 +18,4 @@ Move Game Hub add/edit behavior into the game table and correct selected-state s
1718

1819
PASS - `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub preserves guest browsing and blocks guest saves|Game Hub shows a creator-safe empty state when no projects exist|Game Hub shows a creator-safe unavailable state when project list API fails|Game Hub displays and edits game purpose and member role|Game Hub readiness child rows update from mock game state"`
1920
PASS - `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"`
20-
PASS - `git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs`
21-
21+
PASS - `git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs`
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
assets/theme-v2/css/tables.css
22
tests/playwright/tools/GameHubMockRepository.spec.mjs
33
toolbox/game-hub/game-hub.js
4-
toolbox/game-hub/index.html

0 commit comments

Comments
 (0)