Skip to content

Commit 505fdc3

Browse files
committed
PR_26174_ALFA_016-game-hub-row-edit-add-selected-state
1 parent ef771ff commit 505fdc3

11 files changed

Lines changed: 1129 additions & 363 deletions

assets/theme-v2/css/tables.css

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,11 @@ td {
115115
cursor: pointer
116116
}
117117

118-
.data-table [data-game-row][data-game-active="true"] {
118+
.data-table [data-game-active-cell="true"] {
119119
background: color-mix(in srgb, var(--gold) 14%, var(--panel))
120120
}
121121

122-
.data-table [data-game-row][data-game-active="true"] > th,
123-
.data-table [data-game-row][data-game-active="true"] > td {
122+
.data-table [data-game-active-cell="true"] {
124123
border-bottom-color: var(--gold-border-muted)
125124
}
126125

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
Branch Validation: PASS
2+
3+
PASS - Current branch is pr/26174-ALFA-016-game-hub-row-edit-add-selected-state.
4+
PASS - Branch was created from pr/26174-ALFA-015-game-hub-actions-and-setup-cleanup at ef771ff76.
5+
PASS - Worktree was clean before creating the PR branch.
6+
PASS - Scope is limited to Game Hub table add/edit selected-state behavior, Theme V2 table styling, targeted Playwright coverage, and required reports.
7+
PASS - No protected Project Instructions files were modified.
8+
PASS - No merge to main was performed.
9+
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
Manual Validation Notes
2+
3+
PASS - Confirmed active-game selected styling is on the Game table cell/button, not the Actions edit button.
4+
PASS - Confirmed Edit remains a plain action until it opens an inline edit row.
5+
PASS - Confirmed inline edit row shows Game, Purpose, Status, Owner, Actions columns with Save and Cancel.
6+
PASS - Confirmed Game textbox is visible during edit and read-only because no rename API exists in the current Game Hub contract.
7+
PASS - Confirmed Add Game row appears under the game table and expands to Game, Purpose, Status, Owner, Actions with Save and Cancel.
8+
PASS - Confirmed add and edit saves use the existing repository API/service methods.
9+
PASS - Confirmed Source Idea and Readiness Output child rows remain under expanded game parent rows.
10+
PASS - Confirmed guest users can browse/select games but cannot add or edit.
11+
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
Requirement Checklist: PASS
2+
3+
PASS - Selected state now appears on the Game button/cell for the active game.
4+
PASS - Edit button does not look selected while a row is merely active.
5+
PASS - Add Game button/row appears under the game table.
6+
PASS - Add row includes Game textbox, Purpose dropdown, and Status dropdown.
7+
PASS - Add row actions show Save and Cancel.
8+
PASS - Edit row actions show Save and Cancel.
9+
PASS - Columns remain Game, Purpose, Status, Owner, Actions.
10+
PASS - Source Idea child rows are preserved.
11+
PASS - Readiness Output child rows are preserved.
12+
PASS - table_first_ui.md and the Idea Board table-first add-row/edit-row pattern were followed.
13+
PASS - No browser-owned product data was introduced.
14+
PASS - No silent fallbacks were introduced.
15+
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
Validation Lane: PASS
2+
3+
Commands:
4+
1. npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub preserves guest browsing and blocks guest saves|Game Hub shows a creator-safe empty state when no projects exist|Game Hub shows a creator-safe unavailable state when project list API fails|Game Hub displays and edits game purpose and member role|Game Hub readiness child rows update from mock game state"
5+
Result: PASS - 7 passed.
6+
7+
2. npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"
8+
Result: PASS - 1 passed.
9+
10+
3. git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs
11+
Result: PASS.
12+
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# PR_26174_ALFA_016-game-hub-row-edit-add-selected-state
2+
3+
## Purpose
4+
5+
Move Game Hub add/edit behavior into the game table and correct selected-state styling.
6+
7+
## Summary
8+
9+
- Moved the active-game selected state from the Actions edit button to the Game column cell/button.
10+
- Kept Edit as a plain row action and rendered Save/Cancel only while a row is editing.
11+
- Added a bottom Add Game row that expands into Game, Purpose, and Status fields with Save/Cancel actions.
12+
- Removed the old sidebar add-game form while preserving the existing API/service contract.
13+
- Preserved Game, Purpose, Status, Owner, and Actions columns.
14+
- Preserved Source Idea and Readiness Output child rows under game parent rows.
15+
16+
## Validation
17+
18+
PASS - `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub preserves guest browsing and blocks guest saves|Game Hub shows a creator-safe empty state when no projects exist|Game Hub shows a creator-safe unavailable state when project list API fails|Game Hub displays and edits game purpose and member role|Game Hub readiness child rows update from mock game state"`
19+
PASS - `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"`
20+
PASS - `git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs`
21+
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
assets/theme-v2/css/tables.css
22
tests/playwright/tools/GameHubMockRepository.spec.mjs
3-
tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
43
toolbox/game-hub/game-hub.js
54
toolbox/game-hub/index.html

0 commit comments

Comments
 (0)