Skip to content

Commit 250b32f

Browse files
ToolboxAidToolboxAid
committed
Alphabetize Admin submenu navigation
1 parent cd38b09 commit 250b32f

14 files changed

Lines changed: 406 additions & 163 deletions

‎docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order-branch-validation.md‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# PR_26175_CHARLIE_011 Branch Validation
2+
3+
## Start Gate
4+
5+
- PASS: Current branch was `pr/26175-CHARLIE-010-system-health-history-and-closeout`.
6+
- PASS: Worktree was clean before implementation.
7+
- PASS: Build remained on the current Charlie continuation branch.
8+
- PASS: No rebase was performed.
9+
- PASS: No new root branch was created.
10+
11+
## Final Branch Target
12+
13+
- Branch to push: `pr/26175-CHARLIE-010-system-health-history-and-closeout`
14+
- Expected draft PR to update: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/155
15+
- Merge status: no merge requested or performed.

‎docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order-manual-validation-notes.md‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# PR_26175_CHARLIE_011 Manual Validation Notes
2+
3+
## Admin Submenu Order
4+
5+
Visible labels after the change:
6+
7+
`Admin Tools`, `Analytics`, `Controls`, `Creators`, `DB Viewer`, `Environments`, `Game Migration`, `Infrastructure`, `Invites`, `Moderation`, `Operations`, `Platform Settings`, `Ratings`, `Responsibilities`, `Site Setup`, `System Health`, `Tool Votes`
8+
9+
## Route Preservation
10+
11+
The only source navigation reorder moved this existing item:
12+
13+
- `Creators`
14+
- path remained `admin/users.html`
15+
- route remained `admin-users`
16+
- label remained `Creators`
17+
18+
All other Admin navigation objects remained unchanged.
19+
20+
## Open-Page Check
21+
22+
The targeted Playwright navigation test collected every active Admin submenu href from the rendered submenu and requested each page through the local test server. Every response returned a status below HTTP 400.
23+
24+
## Duplicate Check
25+
26+
The targeted Playwright navigation test checks for duplicate rendered labels and duplicate active hrefs. The targeted unit script also checks duplicate labels and existing active paths.

‎docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order-requirement-checklist.md‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# PR_26175_CHARLIE_011 Requirement Checklist
2+
3+
## Branch Rules
4+
5+
- PASS: Continued on `pr/26175-CHARLIE-010-system-health-history-and-closeout`.
6+
- PASS: Did not return to `main`.
7+
- PASS: Did not rebase.
8+
- PASS: Did not create a new root branch.
9+
- PASS: Hard stop conditions were checked before implementation.
10+
11+
## Objective
12+
13+
- PASS: Admin submenu entries are alphabetized by displayed text.
14+
15+
## Scope
16+
17+
- PASS: Located Admin submenu definition in `src/api/admin-owner-navigation.js`.
18+
- PASS: Sorted submenu entries by displayed text.
19+
- PASS: Preserved routes, URLs, IDs, CSS classes, Theme V2 styling, and existing renderer behavior.
20+
- PASS: Did not rename pages.
21+
- PASS: Did not rename folders.
22+
- PASS: Did not modify page content.
23+
- PASS: No unrelated cleanup.
24+
25+
## Validation
26+
27+
- PASS: Verified submenu labels are alphabetical.
28+
- PASS: Verified every Admin page path exists and every Admin submenu href opens below HTTP 400 in targeted Playwright.
29+
- PASS: Verified no duplicate labels or hrefs.
30+
- PASS: Ran affected Playwright navigation tests.
31+
- PASS: Ran affected targeted unit tests.
32+
33+
## Artifacts
34+
35+
- PASS: `docs_build/dev/reports/codex_review.diff`
36+
- PASS: `docs_build/dev/reports/codex_changed_files.txt`
37+
- PASS: `docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order.md`
38+
- PASS: validation report
39+
- PASS: branch validation report
40+
- PASS: requirement checklist
41+
- PASS: manual validation notes
42+
- PASS: repository ZIP under `tmp/`

‎docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order-validation.md‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# PR_26175_CHARLIE_011 Validation Report
2+
3+
## Commands
4+
5+
- PASS: `node --check src/api/admin-owner-navigation.js`
6+
- PASS: `node --input-type=module` alphabetical/duplicate/path verification script
7+
- Result: `PASS labels=17 active=16`
8+
- Order: `Admin Tools | Analytics | Controls | Creators | DB Viewer | Environments | Game Migration | Infrastructure | Invites | Moderation | Operations | Platform Settings | Ratings | Responsibilities | Site Setup | System Health | Tool Votes`
9+
- PASS: `git diff --check`
10+
- Result: no whitespace errors; CRLF conversion warnings only.
11+
- PASS: `node --test tests/dev-runtime/ApiMenuPathCleanup.test.mjs`
12+
- Result: 6 passed.
13+
- PASS: `node --test --test-name-pattern "Admin and Owner navigation are shared" tests/dev-runtime/ArchitectureCleanupApiNavInvitations.test.mjs`
14+
- Result: 1 passed.
15+
- PASS: `npx playwright test tests/playwright/tools/AdminOwnerNavigationBoundary.spec.mjs --workers=1 --reporter=line`
16+
- Result: 4 passed.
17+
- PASS: `npx playwright test tests/playwright/tools/AdminInvitationsNavPage.spec.mjs --workers=1 --reporter=line`
18+
- Result: 3 passed.
19+
20+
## Note
21+
22+
A non-targeted full-file run of `tests/dev-runtime/ArchitectureCleanupApiNavInvitations.test.mjs` was not used for final validation because its first non-navigation test fails on a pre-existing missing `src/engine/api` directory assertion. The affected navigation subtest passed by name.

‎docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order.md‎

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
# PR_26175_CHARLIE_011 Admin Submenu Alphabetical Order
2+
3+
## Scope
4+
5+
Team: Charlie
6+
7+
Purpose: Alphabetize the Admin submenu by visible menu labels only.
8+
9+
## Branch
10+
11+
- Continuation branch: `pr/26175-CHARLIE-010-system-health-history-and-closeout`
12+
- Start gate: PASS
13+
- Current branch matched the expected Charlie continuation branch.
14+
- Worktree was clean before implementation.
15+
16+
## Changes
17+
18+
- Moved `Creators` into its alphabetical position in `src/api/admin-owner-navigation.js`.
19+
- Preserved each Admin menu item label, path, route id, disabled state, and renderer behavior.
20+
- Updated affected navigation tests that pin visible Admin menu label order.
21+
- Added Playwright coverage of:
22+
- alphabetical visible label order
23+
- duplicate detection
24+
- duplicate href detection
25+
- each Admin submenu href opening with an HTTP status below 400
26+
27+
## Non-Changes
28+
29+
- No page files were renamed.
30+
- No folders were renamed.
31+
- No page content was modified.
32+
- No routes, URLs, permissions, icons, IDs, CSS classes, Theme V2 styling, or event handlers were changed.
33+
- No menu outside the Admin submenu was reordered.
34+
35+
## Validation Summary
36+
37+
- PASS: Admin labels are alphabetical.
38+
- PASS: No duplicate Admin labels.
39+
- PASS: No duplicate Admin hrefs.
40+
- PASS: Every active Admin submenu item points to an existing page path.
41+
- PASS: Every Admin submenu href opened with an HTTP status below 400 in the targeted Playwright navigation test.
42+
- PASS: Targeted unit tests passed.
43+
- PASS: Targeted Playwright navigation tests passed.
44+
45+
## Artifact
46+
47+
- `tmp/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order_delta.zip`

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
1-
# git status --short
2-
3-
4-
# git diff --name-status main...HEAD
5-
A docs_build/dev/reports/PR_26175_OWNER_049-governance-report-merge-batch.md
6-
7-
# git diff --stat main...HEAD
8-
...6175_OWNER_049-governance-report-merge-batch.md | 128 +++++++++++++++++++++
9-
1 file changed, 128 insertions(+)
1+
docs_build/dev/reports/codex_changed_files.txt
2+
docs_build/dev/reports/codex_review.diff
3+
docs_build/dev/reports/coverage_changed_js_guardrail.txt
4+
docs_build/dev/reports/playwright_v8_coverage_report.txt
5+
docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order.md
6+
docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order-branch-validation.md
7+
docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order-manual-validation-notes.md
8+
docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order-requirement-checklist.md
9+
docs_build/dev/reports/PR_26175_CHARLIE_011-admin-submenu-alphabetical-order-validation.md
10+
src/api/admin-owner-navigation.js
11+
tests/dev-runtime/ApiMenuPathCleanup.test.mjs
12+
tests/dev-runtime/ArchitectureCleanupApiNavInvitations.test.mjs
13+
tests/playwright/tools/AdminInvitationsNavPage.spec.mjs
14+
tests/playwright/tools/AdminOwnerNavigationBoundary.spec.mjs

0 commit comments

Comments
 (0)