PR_26175_CHARLIE_010-system-health-history-and-closeout

ToolboxAid · ToolboxAid · commit cd38b098e909 · 2026-06-24T14:33:00.000-04:00
diff --git a/admin/system-health.html b/admin/system-health.html
@@ -43,6 +43,7 @@ <h2>Admin</h2>
                                     <p>Local API Startup</p>
                                     <p>Database Health</p>
                                     <p>Storage Health</p>
+                                    <p>Health Check History</p>
                                     <p>Runtime Environment</p>
                                     <p>Limits &amp; Capacity</p>
                                     <p>Diagnostics Plan</p>
@@ -152,6 +153,23 @@ <h2 id="admin-system-health-title">System Health Tables</h2>
                                 </tbody>
                             </table>
                         </div>
+                        <div class="table-wrapper">
+                            <table class="data-table" aria-label="Health check history">
+                                <caption>Health Check History</caption>
+                                <thead>
+                                    <tr>
+                                        <th scope="col">Time</th>
+                                        <th scope="col">Environment</th>
+                                        <th scope="col">Area</th>
+                                        <th scope="col">Result</th>
+                                        <th scope="col">Summary</th>
+                                    </tr>
+                                </thead>
+                                <tbody data-admin-system-health-history-rows>
+                                    <tr><td>Loading</td><td>Loading</td><td>Current environment</td><td data-health-status="PENDING" title="Reason: health check history has not loaded yet." aria-label="PENDING: health check history has not loaded yet.">PENDING</td><td>Waiting for safe API status.</td></tr>
+                                </tbody>
+                            </table>
+                        </div>
                         <div class="table-wrapper">
                             <table class="data-table" aria-label="Runtime environment">
                                 <caption>Runtime Environment - Alphabetical Variables</caption>
diff --git a/assets/theme-v2/js/admin-system-health.js b/assets/theme-v2/js/admin-system-health.js
@@ -47,6 +47,7 @@ class AdminSystemHealthController {
             node.dataset.adminSystemHealthStorageStatus,
             node,
         ]));
+        this.historyRows = root.querySelector("[data-admin-system-health-history-rows]");
         this.startupRows = root.querySelector("[data-admin-system-health-startup-rows]");
         this.runtimeRows = root.querySelector("[data-admin-system-health-runtime-rows]");
     }
@@ -107,6 +108,7 @@ class AdminSystemHealthController {
         });
         this.renderStartupPending(reason);
         this.renderStoragePending(reason);
+        this.renderHistoryPending(reason);
     }
 
     renderEnvironmentIdentity(environmentIdentity = {}) {
@@ -222,6 +224,45 @@ class AdminSystemHealthController {
         }
     }
 
+    renderHistoryPending(reason) {
+        if (!this.historyRows) {
+            return;
+        }
+        const row = document.createElement("tr");
+        row.append(
+            this.createCell("not available"),
+            this.createCell("current environment"),
+            this.createCell("Health Check History"),
+            this.createStatusCell("PENDING", reason),
+            this.createCell("Safe health check history is not available."),
+        );
+        this.historyRows.replaceChildren(row);
+    }
+
+    renderHealthCheckHistory(historyRows = []) {
+        if (!this.historyRows) {
+            return;
+        }
+        const rows = Array.isArray(historyRows) ? historyRows : [];
+        if (!rows.length) {
+            this.renderHistoryPending("Safe Admin System Health API returned no current-environment health check history rows.");
+            return;
+        }
+        const fragment = document.createDocumentFragment();
+        rows.forEach((historyRow) => {
+            const row = document.createElement("tr");
+            row.append(
+                this.createCell(historyRow.checkedAt),
+                this.createCell(historyRow.environmentName),
+                this.createCell(historyRow.area),
+                this.createStatusCell(historyRow.result || historyRow.status, historyRow.summary),
+                this.createCell(historyRow.summary),
+            );
+            fragment.append(row);
+        });
+        this.historyRows.replaceChildren(fragment);
+    }
+
     runStorageDiagnostics() {
         STORAGE_DIAGNOSTIC_ACTIONS.forEach(({ key }) => {
             this.setStorageStatus(key, "PENDING", "R2 diagnostic is running through the safe Admin System Health API.");
@@ -302,6 +343,7 @@ class AdminSystemHealthController {
             this.renderStartupDiagnostics(data?.localApiStartup || {});
             this.renderStorageStatus(data?.storageStatus || {});
             this.runStorageDiagnostics();
+            this.renderHealthCheckHistory(data?.healthCheckHistory || []);
             this.renderRuntimeEnvironment(data?.runtimeEnvironment || {});
         } catch (error) {
             const message = error instanceof Error ? error.message : "Safe Admin System Health API is unavailable.";
diff --git a/docs_build/dev/reports/PR_26175_CHARLIE_010-system-health-history-and-closeout.md b/docs_build/dev/reports/PR_26175_CHARLIE_010-system-health-history-and-closeout.md
@@ -0,0 +1,68 @@
+# PR_26175_CHARLIE_010 System Health History and Closeout
+
+## Scope
+
+Team: Charlie
+
+Purpose: Add current-environment Health Check History and close out the System Health stacked expansion chain.
+
+## Chain
+
+- `PR_26175_CHARLIE_006-project-instructions-system-health-infrastructure`
+  - Branch: `PR_26175_CHARLIE_006-project-instructions-system-health-infrastructure`
+  - Commit: `c870b812faded383094fb13fc60ae9cfc7f14889`
+  - Result: pushed to origin, not merged.
+- `PR_26175_CHARLIE_007-system-health-environment-identity`
+  - Branch: `pr/26175-CHARLIE-007-system-health-environment-identity`
+  - Commit: `6556e73efcd8ae13b51b56288416c88688e67634`
+  - Draft PR: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/151
+- `PR_26175_CHARLIE_008-system-health-current-database-health`
+  - Branch: `pr/26175-CHARLIE-008-system-health-current-database-health`
+  - Commit: `2603aeb6e5a7ccca516051953cbd70a5a6c94c4b`
+  - Draft PR: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/152
+- `PR_26175_CHARLIE_009-system-health-current-r2-health`
+  - Branch: `pr/26175-CHARLIE-009-system-health-current-r2-health`
+  - Commit: `9740705fbe73dffd43744ab66338f8e4a925eed4`
+  - Draft PR: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/153
+- `PR_26175_CHARLIE_010-system-health-history-and-closeout`
+  - Branch: `pr/26175-CHARLIE-010-system-health-history-and-closeout`
+  - Commit and draft PR URL are assigned after this report is committed and pushed.
+
+## Changes
+
+- Added Health Check History to the Admin System Health page.
+- Health Check History is derived from the current deployment only:
+  - Environment Summary
+  - Database Health
+  - Storage Health
+  - Runtime Health
+- Warning and failure rows are generated only from current-environment health rows.
+- Creator sessions remain blocked from Admin System Health and do not trigger status or storage health requests.
+
+## Governance
+
+- PASS: System Health is one page per deployed environment.
+- PASS: Each deployment actively checks only itself.
+- PASS: The Environment Map remains a static reference for Local, DEV, IST, UAT, and PRD.
+- PASS: System Health does not actively check peer databases or peer R2 folders.
+- PASS: Cancelled initiatives remain not doing:
+  - Environment Isolation & Developer Experience
+  - multi-port workspace framework
+  - Alpha/Beta/User runtime separation
+  - runtime port management initiative
+
+## Validation
+
+- PASS: `node --check src/dev-runtime/server/local-api-router.mjs`
+- PASS: `node --check assets/theme-v2/js/admin-system-health.js`
+- PASS: `git diff --check`
+- PASS: `node --test tests/dev-runtime/AdminHealthOperations.test.mjs`
+- PASS: `node --test tests/dev-runtime/PublicEnvironmentConfig.test.mjs`
+- PASS: `npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1 --reporter=line`
+
+## Artifacts
+
+- `tmp/PR_26175_CHARLIE_007-system-health-environment-identity_delta.zip`
+- `tmp/PR_26175_CHARLIE_008-system-health-current-database-health_delta.zip`
+- `tmp/PR_26175_CHARLIE_009-system-health-current-r2-health_delta.zip`
+- `tmp/PR_26175_CHARLIE_010-system-health-history-and-closeout_delta.zip`
diff --git a/docs_build/dev/reports/coverage_changed_js_guardrail.txt b/docs_build/dev/reports/coverage_changed_js_guardrail.txt
@@ -7,7 +7,7 @@ Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
 (0%) src/dev-runtime/server/local-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(89%) assets/theme-v2/js/admin-system-health.js - executed lines 294/294; executed functions 33/37
+(88%) assets/theme-v2/js/admin-system-health.js - executed lines 334/334; executed functions 35/40
 
 Guardrail warnings:
 (0%) src/dev-runtime/server/local-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
diff --git a/docs_build/dev/reports/playwright_v8_coverage_report.txt b/docs_build/dev/reports/playwright_v8_coverage_report.txt
@@ -18,7 +18,7 @@ Exercised tool entry points detected:
 
 Changed runtime JS files covered:
 (0%) src/dev-runtime/server/local-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(89%) assets/theme-v2/js/admin-system-health.js - executed lines 294/294; executed functions 33/37
+(88%) assets/theme-v2/js/admin-system-health.js - executed lines 334/334; executed functions 35/40
 
 Files with executed line/function counts where available:
 (36%) src/api/server-api-client.js - executed lines 167/167; executed functions 5/14
@@ -28,7 +28,7 @@ Files with executed line/function counts where available:
 (74%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 1001/1001; executed functions 69/93
 (80%) src/api/admin-owner-navigation.js - executed lines 42/42; executed functions 4/5
 (83%) assets/js/shared/status.js - executed lines 37/37; executed functions 5/6
-(89%) assets/theme-v2/js/admin-system-health.js - executed lines 294/294; executed functions 33/37
+(88%) assets/theme-v2/js/admin-system-health.js - executed lines 334/334; executed functions 35/40
 (91%) assets/theme-v2/js/admin-owner-navigation.js - executed lines 58/58; executed functions 10/11
 (100%) src/api/admin-system-health-api-client.js - executed lines 19/19; executed functions 3/3
 
@@ -39,4 +39,4 @@ Changed JS files considered:
 (0%) src/dev-runtime/server/local-api-router.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/dev-runtime/AdminHealthOperations.test.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/AdminHealthOperationsPage.spec.mjs - changed JS file not collected as browser runtime coverage
-(89%) assets/theme-v2/js/admin-system-health.js - changed JS file with browser V8 coverage
+(88%) assets/theme-v2/js/admin-system-health.js - changed JS file with browser V8 coverage
diff --git a/src/dev-runtime/server/local-api-router.mjs b/src/dev-runtime/server/local-api-router.mjs
@@ -1028,6 +1028,71 @@ function systemHealthRuntimeEnvironment(env = process.env) {
   };
 }
 
+function systemHealthHistoryRow({ checkedAt, environmentName, area, result, summary, kind = "recent check" }) {
+  return {
+    area,
+    checkedAt,
+    environmentName,
+    kind,
+    result: normalizeHealthStatus(result),
+    summary: String(summary || "No summary returned."),
+  };
+}
+
+function systemHealthCheckHistory({
+  checkedAt,
+  databaseStatus = {},
+  environmentIdentity = {},
+  runtimeEnvironment = {},
+  storageStatus = {},
+}) {
+  const environmentName = environmentIdentity.name || "Unknown";
+  const databaseResponseTime = Number.isFinite(databaseStatus.responseTimeMs)
+    ? `${databaseStatus.responseTimeMs} ms`
+    : "not available";
+  const recentChecks = [
+    systemHealthHistoryRow({
+      area: "Environment Summary",
+      checkedAt,
+      environmentName,
+      result: environmentIdentity.status,
+      summary: `Current deployment ${environmentName}; hosting ${environmentIdentity.hostingModel || "not configured"}; storage folder ${environmentIdentity.storageFolder || "not configured"}.`,
+    }),
+    systemHealthHistoryRow({
+      area: "Database Health",
+      checkedAt,
+      environmentName,
+      result: databaseStatus.connectivityStatus || databaseStatus.status,
+      summary: `${databaseStatus.databaseType || "PostgreSQL"} connectivity ${databaseStatus.connectivity || "not configured"}; response time ${databaseResponseTime}; version ${databaseStatus.version || "not available"}.`,
+    }),
+    systemHealthHistoryRow({
+      area: "Storage Health",
+      checkedAt,
+      environmentName,
+      result: storageStatus.status,
+      summary: `Cloudflare R2 folder ${storageStatus.environmentFolder || environmentIdentity.storageFolder || "not configured"}; bucket ${storageStatus.configured ? "configured" : "not configured"}; last checked ${storageStatus.lastChecked || checkedAt}.`,
+    }),
+    systemHealthHistoryRow({
+      area: "Runtime Health",
+      checkedAt,
+      environmentName,
+      result: runtimeEnvironment.status,
+      summary: runtimeEnvironment.message || "Runtime environment health unavailable.",
+    }),
+  ];
+  const issueRows = recentChecks
+    .filter((row) => row.result !== "PASS")
+    .map((row) => systemHealthHistoryRow({
+      area: `${row.area} ${row.result === "FAIL" ? "Failure" : "Warning"}`,
+      checkedAt: row.checkedAt,
+      environmentName: row.environmentName,
+      kind: row.result === "FAIL" ? "failure" : "warning",
+      result: row.result,
+      summary: row.summary,
+    }));
+  return [...recentChecks, ...issueRows];
+}
+
 function systemHealthR2Readiness(storageStatus) {
   const credentialsConfigured = storageStatus.accessKeyConfigured === true && storageStatus.secretKeyConfigured === true;
   const configurationReady = storageStatus.configured === true
@@ -3838,6 +3903,13 @@ LIMIT 1;
     const r2Readiness = systemHealthR2Readiness(storageStatus);
     const runtimeEnvironment = systemHealthRuntimeEnvironment();
     const operationsHealth = adminOperationsHealth(this.standaloneTables);
+    const healthCheckHistory = systemHealthCheckHistory({
+      checkedAt,
+      databaseStatus,
+      environmentIdentity,
+      runtimeEnvironment,
+      storageStatus,
+    });
     const importBlocked = promotionFoundation.importOverwriteAllowed === false
       && promotionFoundation.browserExecutionAllowed === false
       && promotionFoundation.destructiveOperationsAllowed === false;
@@ -3961,6 +4033,7 @@ LIMIT 1;
       message: "Admin System Health loaded safe status only.",
       environmentIdentity,
       environmentMap,
+      healthCheckHistory,
       operationsHealth,
       overview,
       pressureLabels: SYSTEM_HEALTH_LIMIT_PRESSURE_LABELS,
diff --git a/tests/dev-runtime/AdminHealthOperations.test.mjs b/tests/dev-runtime/AdminHealthOperations.test.mjs
@@ -144,6 +144,14 @@ test("Admin can view operational health while Creator sessions are blocked", asy
       assert.equal(typeof health.databaseStatus.version, "string");
       assert.equal(health.storageStatus.environmentFolder, "/local");
       assert.equal(typeof health.storageStatus.lastChecked, "string");
+      assert.equal(Array.isArray(health.healthCheckHistory), true);
+      assert.deepEqual(
+        health.healthCheckHistory.slice(0, 4).map((row) => row.area),
+        ["Environment Summary", "Database Health", "Storage Health", "Runtime Health"],
+      );
+      assert.equal(health.healthCheckHistory.every((row) => row.environmentName === "Local"), true);
+      assert.equal(JSON.stringify(health.healthCheckHistory).includes("/dev"), false);
+      assert.equal(JSON.stringify(health.healthCheckHistory).includes("/uat"), false);
       assert.deepEqual(
         health.environmentMap.map((row) => row.name),
         ["Local", "DEV", "IST", "UAT", "PRD"],
diff --git a/tests/playwright/tools/AdminHealthOperationsPage.spec.mjs b/tests/playwright/tools/AdminHealthOperationsPage.spec.mjs
@@ -164,6 +164,19 @@ test("Admin System Health renders Postgres diagnostics through the safe status A
     await expect(page.locator("[data-admin-system-health-storage-value='upload']")).toContainText("/dev");
     await expect(page.locator("[data-admin-system-health-storage-value='read']")).not.toHaveText("Health object");
     await expect(page.locator("[data-admin-system-health-storage-value='delete']")).not.toHaveText("Health object");
+    const historyTable = page.getByRole("table", { name: "Health check history" });
+    await expect(historyTable).toContainText("DEV");
+    await expect(historyTable).toContainText("Environment Summary");
+    await expect(historyTable).toContainText("Database Health");
+    await expect(historyTable).toContainText("Storage Health");
+    await expect(historyTable).toContainText("Runtime Health");
+    await expect(historyTable).not.toContainText("IST");
+    await expect(historyTable).not.toContainText("UAT");
+    await expect(historyTable).not.toContainText("PRD");
+    await expect(historyTable).not.toContainText("/local");
+    await expect(historyTable).not.toContainText("/ist");
+    await expect(historyTable).not.toContainText("/uat");
+    await expect(historyTable).not.toContainText("/prd");
     await expect(page.getByRole("table", { name: "Runtime environment" })).toContainText("********");
     await expect(page.getByRole("table", { name: "Runtime environment" })).toContainText("GAMEFOUNDRY_ADMIN_HEALTH_DATABASE_URL");
     await expect(page.getByRole("table", { name: "Runtime environment" })).toContainText("GAMEFOUNDRY_ADMIN_HEALTH_PUBLIC_FLAG");
@@ -216,6 +229,7 @@ test("Creator sessions cannot access Admin System Health operations", async ({ p
     await expect(page.locator("[data-session-access-blocked='admin']")).toBeVisible();
     await expect(page.getByRole("table", { name: "Environment identity" })).toHaveCount(0);
     await expect(page.getByRole("table", { name: "Environment map" })).toHaveCount(0);
+    await expect(page.getByRole("table", { name: "Health check history" })).toHaveCount(0);
     expect(context.requestUrls.some((url) => url.includes("/api/admin/system-health/status"))).toBe(false);
     expect(context.requestUrls.some((url) => url.includes("/api/admin/system-health/storage-connectivity-action"))).toBe(false);
     expect(context.pageErrors).toEqual([]);
