Skip to content

Fix ThangsPublisher selectors and add parallel publishing#12

Merged
TheCraftyMaker merged 1 commit into
masterfrom
feat/thangs-publisher-fixes
Mar 22, 2026
Merged

Fix ThangsPublisher selectors and add parallel publishing#12
TheCraftyMaker merged 1 commit into
masterfrom
feat/thangs-publisher-fixes

Conversation

@TheCraftyMaker

Copy link
Copy Markdown
Owner

Fixes discovered through live testing of the Thangs upload flow.

Changes

ThangsPublisher:

  • Use RunAndWaitForFileChooserAsync for model file upload (React-compatible)
  • Fix audience trigger: real ClickAsync on aria-haspopup span with retry loop instead of DispatchEventAsync
  • Fix save button selector: Thangs uses data-test-id (hyphenated), not data-testid; target save-and-publish button
  • Fix close button: ClickAsync instead of DispatchEventAsync

PrintablesPublisher:

  • Remove Console.ReadLine pause that blocked automation
  • Add Disclaimer implementation

PublishCommand:

  • Run publishers in parallel via Task.WhenAll with shared console lock

Test plan

  • ThangsPublisher ran end-to-end without manual intervention

- ThangsPublisher: use RunAndWaitForFileChooserAsync for React-compatible
  model file upload; fix audience trigger to real ClickAsync with retry
  loop; fix save button selector (data-test-id not data-testid); use
  save-and-publish button; fix close button to ClickAsync
- PrintablesPublisher: remove Console.ReadLine pause; add Disclaimer
- PublishCommand: run publishers in parallel via Task.WhenAll

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@TheCraftyMaker
TheCraftyMaker merged commit d9445ae into master Mar 22, 2026
5 checks passed
@TheCraftyMaker
TheCraftyMaker deleted the feat/thangs-publisher-fixes branch March 22, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant