Skip to content

fix(simplex): raise error instead of silent failure on max iterations#14799

Closed
Amruta-32 wants to merge 2 commits into
TheAlgorithms:masterfrom
Amruta-32:fix-simplex-maxiter
Closed

fix(simplex): raise error instead of silent failure on max iterations#14799
Amruta-32 wants to merge 2 commits into
TheAlgorithms:masterfrom
Amruta-32:fix-simplex-maxiter

Conversation

@Amruta-32

Copy link
Copy Markdown

Fixes silent failure in run_simplex().

Previously, when the maximum iteration limit was reached, the function returned an empty dictionary, making debugging impossible.

This change raises a ValueError instead, making the failure explicit and easier to debug.

Behavior change:

  • Before: return {}
  • After: raise ValueError with descriptive message

@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@Amruta-32, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added invalid awaiting reviews This PR is ready to be reviewed labels Jun 12, 2026
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant