-
Notifications
You must be signed in to change notification settings - Fork 21.2k
Add LongestCommonSubstring Implementation #7464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rosander0
wants to merge
2
commits into
TheAlgorithms:master
Choose a base branch
from
Rosander0:add-longest-common-substring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
55 changes: 55 additions & 0 deletions
55
src/main/java/com/thealgorithms/strings/LongestCommonSubstring.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| package com.thealgorithms.strings; | ||
|
|
||
| /** | ||
| * Longest Common Substring finds the longest string that is a | ||
| * contiguous substring of two input strings. | ||
| * Example: "abcdef" and "zcdemf" -> "cde" | ||
| * | ||
| * @see <a href="https://en.wikipedia.org/wiki/Longest_common_substring"> | ||
| * Wikipedia: Longest Common Substring</a> | ||
| * | ||
| * author: Vraj Prajapati @Rosander0 | ||
| */ | ||
| public final class LongestCommonSubstring { | ||
|
|
||
| private LongestCommonSubstring() { | ||
| // Utility class | ||
| } | ||
|
|
||
| /** | ||
| * Finds the longest common substring of two strings. | ||
| * | ||
| * @param a First input string | ||
| * @param b Second input string | ||
| * @return The longest common substring, or empty string if none exists. | ||
| * If multiple substrings share the maximum length, the first one found is returned. | ||
| */ | ||
| public static String longestCommonSubstring(final String a, final String b) { | ||
| if (a == null || b == null || a.isEmpty() || b.isEmpty()) { | ||
| return ""; | ||
| } | ||
|
|
||
| int[][] dp = new int[a.length() + 1][b.length() + 1]; | ||
| int maxLength = 0; | ||
| int endIndex = 0; | ||
|
|
||
| for (int i = 1; i <= a.length(); i++) { | ||
| for (int j = 1; j <= b.length(); j++) { | ||
| if (a.charAt(i - 1) == b.charAt(j - 1)) { | ||
| dp[i][j] = dp[i - 1][j - 1] + 1; | ||
| if (dp[i][j] > maxLength) { | ||
| maxLength = dp[i][j]; | ||
| endIndex = i; | ||
| } | ||
| } else { | ||
| dp[i][j] = 0; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (maxLength == 0) { | ||
| return ""; | ||
| } | ||
| return a.substring(endIndex - maxLength, endIndex); | ||
|
Rosander0 marked this conversation as resolved.
|
||
| } | ||
| } | ||
36 changes: 36 additions & 0 deletions
36
src/test/java/com/thealgorithms/strings/LongestCommonSubstringTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package com.thealgorithms.strings; | ||
| // author: Vraj Prajapati @Rosander0 | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class LongestCommonSubstringTest { | ||
|
|
||
| @Test | ||
| public void testNullOrEmptyInputs() { | ||
| assertEquals("", LongestCommonSubstring.longestCommonSubstring(null, "abc")); | ||
| assertEquals("", LongestCommonSubstring.longestCommonSubstring("abc", null)); | ||
| assertEquals("", LongestCommonSubstring.longestCommonSubstring("", "abc")); | ||
| assertEquals("", LongestCommonSubstring.longestCommonSubstring("abc", "")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNormalSubstrings() { | ||
| assertEquals("cde", LongestCommonSubstring.longestCommonSubstring("abcdef", "zcdemf")); | ||
| assertEquals("abc", LongestCommonSubstring.longestCommonSubstring("abc", "abc")); | ||
| assertEquals("cdef", LongestCommonSubstring.longestCommonSubstring("abcdef", "cdefgh")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSingleCharacterAndNoMatch() { | ||
| assertEquals("a", LongestCommonSubstring.longestCommonSubstring("a", "a")); | ||
| assertEquals("", LongestCommonSubstring.longestCommonSubstring("abc", "xyz")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testMultipleMatchesFirstLongest() { | ||
| // Keeps the first matched longest substring when lengths are tied | ||
| assertEquals("abc", LongestCommonSubstring.longestCommonSubstring("abcXdef", "abcYdef")); | ||
|
Rosander0 marked this conversation as resolved.
|
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.