Add flush() method to SSHSocket, SSHClient, and SSHChannel#185
Merged
vicajilau merged 6 commits intoJul 14, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 55.42% 55.88% +0.45%
==========================================
Files 66 66
Lines 5452 5470 +18
==========================================
+ Hits 3022 3057 +35
+ Misses 2430 2413 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…t, channels, and sessions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
flush()method to theSSHSocket,SSHClient, andSSHChannelclasses, allowing users to force the flushing of any buffered outgoing data. The implementation is propagated across the main library code, channel controllers, and test fakes to ensure consistent behavior and testability.New flush functionality
flush()method to theSSHSocketabstract class and implemented it in all concrete socket classes, including_SSHNativeSocketandSSHForwardChannel, to force flushing of buffered outgoing data.flush()inSSHTransportto call the underlying socket'sflush()method, ensuring transport-level flushing.flush()method toSSHClientthat delegates to the transport layer, and passed this method intoSSHChannelControllerfor channel-level flushing.flush()method onSSHChannelthat delegates to its controller, and updatedSSHChannelControllerto support an optionalonFlushcallback and provide aflush()method.Test support
flush()method, ensuring compatibility with the new interface in tests.Documentation
CHANGELOG.mdto document the addition of theflush()method to the public API.