fix(rate-plans): the update DTO never allowed deactivation - #320
Merged
telivity-otaip merged 2 commits intoAug 13, 2026
Merged
Conversation
UpdateRatePlanDto is a partial of the create DTO, and the create DTO never
carried isActive (a schema default) — so the API has no way to retire a
rate plan. PATCH {"isActive": false} answers 400 "property isActive should
not exist", and the only lever left is validTo, which expires a plan but
leaves it active in every isActive-filtered list.
isActive joins the UPDATE DTO only: plans are created active, and retiring
one is an explicit later act.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateRatePlanDtois a partial of the create DTO, and the create DTO never carriedisActive(it's a schema default) — so the API has no way to retire a rate plan.PATCH {"isActive": false}answers400 property isActive should not exist, and the only lever left isvalidTo, which expires a plan but leaves itisActive=truein every filtered list.isActivejoins the update DTO only: plans are created active, and retiring one is an explicit later act.