Skip to content

test: edge cases for salary-compare and offer-compare helpers - #28

Merged
telivity-otaip merged 1 commit into
TelivityAI:mainfrom
aryanB1706:tests/comp-edge-cases
Aug 13, 2026
Merged

test: edge cases for salary-compare and offer-compare helpers#28
telivity-otaip merged 1 commit into
TelivityAI:mainfrom
aryanB1706:tests/comp-edge-cases

Conversation

@aryanB1706

Copy link
Copy Markdown
Contributor

Summary

Adds node tests for the honest-comp helpers (web/lib/salary-compare.mjs, web/lib/offer-compare.mjs) — closes #24.

What's covered

  • Partial bands: min-only / max-only / both-empty for target and posted bands
  • Currency: missing defaults to USD; mismatch stays labeled per row, no silent conversion
  • Offer compare: 2 roles with structured fields vs unstructured notes (notes never mined for numbers)
  • Guard: helpers never fabricate a market average (gap kinds/labels + rows keep exact input bounds)

Verification

  • npm run test:career-os green
  • Full npm test green
  • Test-only change; no module behavior or UI touched
  • Fixtures are fictional

@telivity-otaip
telivity-otaip merged commit 8e75151 into TelivityAI:main Aug 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests: edge cases for salary-compare and offer-compare helpers

2 participants