Configure submit recovery attempts#21
Merged
Merged
Conversation
Assisted-By: devx/12bfa114-4ee7-4929-a37c-98018f6b0f41
f6dcca5 to
e5cf7d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submit_recovery_attemptsplumbing with OSS default 2 attempts--submit-recovery-attemptsontangle sdk pipeline-runs submitand route submits through the recovery-aware run pathContext
Delayed Tangle run registration can make a successful submission look like a failed submit. The retry path already freezes the body and annotates a submission id, but short recovery lookups can miss runs that become searchable several seconds later, causing duplicate submissions. This keeps the conservative OSS default at two recovery lookups while allowing downstream deployments to opt into the full wait window.
Testing
uv run pytest tests/test_pipeline_runs_cli.py -quv run ruff check packages/tangle-cli/src/tangle_cli/__init__.py packages/tangle-cli/src/tangle_cli/pipeline_run_manager.py packages/tangle-cli/src/tangle_cli/pipeline_runner.py packages/tangle-cli/src/tangle_cli/pipeline_runs_cli.py tests/test_pipeline_runs_cli.py