Skip to content

Upgrade solidjs beta 29 - #7928

Open
brenelz wants to merge 2 commits into
solid-router-v2-prefrom
upgrade-solidjs-beta-29
Open

Upgrade solidjs beta 29#7928
brenelz wants to merge 2 commits into
solid-router-v2-prefrom
upgrade-solidjs-beta-29

Conversation

@brenelz

@brenelz brenelz commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Upgrades to the latest Solid 2.0 beta (skips over beta.28) and the latest plugin.

  • solid-js, @solidjs/web, babel-preset-solid2.0.0-beta.29
  • vite-plugin-solid3.0.0-next.21 (peer-requires >=2.0.0-beta.29, ships @dom-expressions/compiler@0.50.0-next.34)

No lockfile surgery was needed — the transitive babel-preset-solid resolved to beta.29 on a plain install.

Verification

Both commits were verified independently; the results below are for the final state (beta.29 + next.21).

Suite Result
packages/solid-router test:unit (client) 814 passed, 2 skipped, no type errors
packages/solid-router test:unit (server) 2 passed
e2e/solid-start/basic 80 passed, 4 skipped
e2e/solid-router/basic-file-based 120 passed
pnpm build:all 43 projects

All counts match the beta.27 baseline — no regressions.

Upgrade `solid-js`, `@solidjs/web` and `babel-preset-solid` to
`2.0.0-beta.29`, and `vite-plugin-solid` to `3.0.0-next.20`
(peer-requires `>=2.0.0-beta.28`).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fc15c39a-701e-4b32-ab76-1be0c5fe591d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit fd03799

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 13m 2s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 18s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-30 23:56:17 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

6 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/solid-router 2.0.0-beta.28 → 2.0.0-beta.29 Changeset
@tanstack/solid-router-devtools 2.0.0-beta.23 → 2.0.0-beta.24 Changeset
@tanstack/solid-router-ssr-query 2.0.0-beta.29 → 2.0.0-beta.30 Changeset
@tanstack/solid-start 2.0.0-beta.29 → 2.0.0-beta.30 Changeset
@tanstack/solid-start-client 2.0.0-beta.28 → 2.0.0-beta.29 Changeset
@tanstack/solid-start-server 2.0.0-beta.28 → 2.0.0-beta.29 Changeset

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 34a8313ff9e6
  • Measured at: 2026-07-30T23:42:38.184Z
  • Baseline source: history:821295080766
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.37 KiB +26 B (+0.03%) 87.24 KiB 273.88 KiB 75.99 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-router.full 91.10 KiB +42 B (+0.05%) 90.96 KiB 285.78 KiB 79.15 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.minimal 41.29 KiB +5.76 KiB (+16.22%) 41.16 KiB 120.63 KiB 37.25 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.full 46.38 KiB +5.80 KiB (+14.29%) 46.26 KiB 136.28 KiB 41.85 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.minimal 53.07 KiB +69 B (+0.13%) 52.94 KiB 150.12 KiB 47.70 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.full 59.03 KiB +99 B (+0.16%) 58.90 KiB 168.88 KiB 52.93 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.minimal 102.03 KiB +41 B (+0.04%) 101.89 KiB 322.31 KiB 88.32 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.deferred-hydration 102.76 KiB +40 B (+0.04%) 101.91 KiB 323.69 KiB 88.91 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.full 105.45 KiB +87 B (+0.08%) 105.31 KiB 332.24 KiB 91.23 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.minimal 99.74 KiB +48 B (+0.05%) 99.57 KiB 316.74 KiB 85.81 KiB ▁▁▁▁▁▁▃▃▃▃▃█
react-start.rsbuild.minimal-iife 100.14 KiB +51 B (+0.05%) 99.98 KiB 317.67 KiB 86.21 KiB ▁▁▁▁▁▁▃▃▃▃▃█
react-start.rsbuild.full 102.96 KiB +59 B (+0.06%) 102.79 KiB 326.79 KiB 88.60 KiB ▁▁▁▁▁▁▂▂▂▂▂█
solid-start.minimal 68.84 KiB +19.23 KiB (+38.77%) 68.71 KiB 205.13 KiB 61.20 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.deferred-hydration 72.71 KiB +19.84 KiB (+37.53%) 69.23 KiB 213.87 KiB 64.84 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.full 72.75 KiB +17.32 KiB (+31.26%) 72.61 KiB 216.71 KiB 64.55 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-start.minimal 71.13 KiB +104 B (+0.14%) 71.00 KiB 207.37 KiB 63.03 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-start.full 75.13 KiB +101 B (+0.13%) 75.00 KiB 220.01 KiB 66.37 KiB ▁▁▁▁▁▁▁▁▁▁▁█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-new Bot commented Jul 30, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7928

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7928

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7928

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7928

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7928

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7928

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7928

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7928

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7928

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7928

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7928

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7928

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7928

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7928

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7928

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7928

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7928

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7928

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7928

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7928

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7928

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7928

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7928

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7928

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7928

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7928

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7928

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7928

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7928

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7928

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7928

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7928

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7928

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7928

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7928

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7928

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7928

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7928

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7928

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7928

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7928

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7928

commit: 33424bc

Peer-requires `>=2.0.0-beta.29` (already satisfied) and ships
`@dom-expressions/compiler@0.50.0-next.34`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@codspeed-hq

codspeed-hq Bot commented Jul 30, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 58.11%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
🆕 173 new benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation ssr request loop (react) 330.5 ms 77.9 ms ×4.2
Simulation client-side navigation loop (solid) 72.6 ms 43.1 ms +68.69%
Simulation ssr request loop (vue) 420.3 ms 283.9 ms +48.05%
Simulation ssr request loop (solid) 174.6 ms 142.6 ms +22.47%
Simulation client-side navigation loop (react) 56.3 ms 50.3 ms +11.85%
Simulation client-side navigation loop (vue) 83 ms 77.1 ms +7.67%
🆕 Simulation ssr not-found (vue) N/A 169.4 ms N/A
🆕 Simulation ssr redirect (vue) N/A 68.2 ms N/A
🆕 Simulation ssr head (vue) N/A 326.9 ms N/A
🆕 Simulation ssr loaders (vue) N/A 136.7 ms N/A
🆕 Simulation ssr selective (vue) N/A 139.7 ms N/A
🆕 Simulation ssr server-fn GET (vue) N/A 74.4 ms N/A
🆕 Simulation ssr server-fn POST (vue) N/A 71.4 ms N/A
🆕 Simulation ssr server-route middleware (vue) N/A 63.3 ms N/A
🆕 Simulation ssr server-route (vue) N/A 60.8 ms N/A
🆕 Simulation ssr streaming deferred (vue) N/A 105.5 ms N/A
🆕 Simulation ssr assets inline-css cdn (vue) N/A 188.1 ms N/A
🆕 Simulation ssr assets linked-css control (vue) N/A 215.3 ms N/A
🆕 Simulation ssr before-load chain (vue) N/A 184.5 ms N/A
🆕 Simulation ssr control-flow error 500 (vue) N/A 197.9 ms N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing upgrade-solidjs-beta-29 (33424bc) with solid-router-v2-pre (67a9040)1

Open in CodSpeed

Footnotes

  1. No successful run was found on solid-router-v2-pre (1d589e6) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant