Device license changes - #596
Open
KenVanHoeylandt wants to merge 3 commits into
Open
Conversation
📝 WalkthroughWalkthroughExpanded 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Devices/btt-panda-touch/LICENSE-Apache-2.0.md (1)
7-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winHandle Markdownlint warnings without changing the license text.
All added Apache license copies trigger heading hierarchy/style warnings. Prefer excluding
LICENSE-Apache-2.0.mdfiles from MD001/MD003, or apply one consistent formatting transformation to every copy rather than changing only selected documents.
Devices/btt-panda-touch/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/cyd-2432s024c/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/cyd-2432s024r/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/cyd-2432s028r/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/lilygo-tdongle-s3/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/lilygo-tlora-pager/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/m5stack-cardputer-adv/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/m5stack-cardputer/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/m5stack-core2/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/m5stack-cores3/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Devices/m5stack-papers3/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 48eddc95-34ec-49c9-8d3e-b7a91887931f
📒 Files selected for processing (53)
Devices/btt-panda-touch/LICENSE-Apache-2.0.mdDevices/cyd-2432s024c/LICENSE-Apache-2.0.mdDevices/cyd-2432s024r/LICENSE-Apache-2.0.mdDevices/cyd-2432s028r/LICENSE-Apache-2.0.mdDevices/cyd-2432s028rv3/LICENSE-Apache-2.0.mdDevices/cyd-2432s032c/LICENSE-Apache-2.0.mdDevices/cyd-3248s035c/LICENSE-Apache-2.0.mdDevices/cyd-4848s040c/LICENSE-Apache-2.0.mdDevices/cyd-8048s043c/LICENSE-Apache-2.0.mdDevices/cyd-e32r28t/LICENSE-Apache-2.0.mdDevices/cyd-e32r32p/LICENSE-Apache-2.0.mdDevices/elecrow-crowpanel-advance-28/LICENSE-Apache-2.0.mdDevices/elecrow-crowpanel-advance-35/LICENSE-Apache-2.0.mdDevices/elecrow-crowpanel-advance-50/LICENSE-Apache-2.0.mdDevices/elecrow-crowpanel-basic-28/LICENSE-Apache-2.0.mdDevices/elecrow-crowpanel-basic-35/LICENSE-Apache-2.0.mdDevices/elecrow-crowpanel-basic-50/LICENSE-Apache-2.0.mdDevices/generic-esp32/LICENSE-Apache-2.0.mdDevices/generic-esp32c6/LICENSE-Apache-2.0.mdDevices/generic-esp32p4/LICENSE-Apache-2.0.mdDevices/generic-esp32s3/LICENSE-Apache-2.0.mdDevices/guition-jc1060p470ciwy/LICENSE-Apache-2.0.mdDevices/guition-jc2432w328c/LICENSE-Apache-2.0.mdDevices/guition-jc8048w550c/LICENSE-Apache-2.0.mdDevices/heltec-wifi-lora-32-v3/LICENSE-Apache-2.0.mdDevices/lilygo-tdeck-max/LICENSE-GPL-3.0.mdDevices/lilygo-tdeck-plus/LICENSE-Apache-2.0.mdDevices/lilygo-tdeck-pro/LICENSE-GPL-3.0.mdDevices/lilygo-tdeck/LICENSE-Apache-2.0.mdDevices/lilygo-tdisplay-s3/LICENSE-Apache-2.0.mdDevices/lilygo-tdisplay-s3/source/module.cppDevices/lilygo-tdisplay/LICENSE-Apache-2.0.mdDevices/lilygo-tdongle-s3/LICENSE-Apache-2.0.mdDevices/lilygo-thmi/LICENSE-GPL-3.0.mdDevices/lilygo-tlora-pager/LICENSE-Apache-2.0.mdDevices/m5stack-cardputer-adv/LICENSE-Apache-2.0.mdDevices/m5stack-cardputer/LICENSE-Apache-2.0.mdDevices/m5stack-core2/LICENSE-Apache-2.0.mdDevices/m5stack-cores3/LICENSE-Apache-2.0.mdDevices/m5stack-papers3/LICENSE-Apache-2.0.mdDevices/m5stack-stackchan/LICENSE-Apache-2.0.mdDevices/m5stack-stickc-plus2/LICENSE-Apache-2.0.mdDevices/m5stack-sticks3/LICENSE-Apache-2.0.mdDevices/m5stack-tab5/LICENSE-Apache-2.0.mdDevices/simulator/LICENSE-Apache-2.0.mdDevices/unphone/LICENSE-Apache-2.0.mdDevices/waveshare-esp32-s3-geek/LICENSE-Apache-2.0.mdDevices/waveshare-s3-lcd-13/LICENSE-Apache-2.0.mdDevices/waveshare-s3-touch-lcd-128/LICENSE-Apache-2.0.mdDevices/waveshare-s3-touch-lcd-147/LICENSE-Apache-2.0.mdDevices/waveshare-s3-touch-lcd-43/LICENSE-Apache-2.0.mdDevices/wireless-tag-wt32-sc01-plus/LICENSE-Apache-2.0.mdLICENSE.md
💤 Files with no reviewable changes (1)
- Devices/lilygo-tdisplay-s3/source/module.cpp
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Tests/SdkIntegration/LICENSE-Apache-2.0.md (1)
7-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winNormalize or exempt the Markdown heading structure in the Apache license copies.
All four files skip heading levels at Lines 7 and 9 and mix ATX headings with a setext title, triggering the same markdownlint warnings.
Tests/SdkIntegration/LICENSE-Apache-2.0.md#L7-L9: normalize or exempt these headings.Tests/TactilityFreeRtos/LICENSE-Apache-2.0.md#L7-L9: normalize or exempt these headings.Tests/TactilityKernel/LICENSE-Apache-2.0.md#L7-L9: normalize or exempt these headings.Tests/crypt-module/LICENSE-Apache-2.0.md#L7-L9: normalize or exempt these headings.Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b31357a9-ba80-4997-a5d0-5a15e4331cae
📒 Files selected for processing (6)
LICENSE.mdTests/SdkIntegration/LICENSE-Apache-2.0.mdTests/Tactility/LICENSE-GPL-3.0.mdTests/TactilityFreeRtos/LICENSE-Apache-2.0.mdTests/TactilityKernel/LICENSE-Apache-2.0.mdTests/crypt-module/LICENSE-Apache-2.0.md
🚧 Files skipped from review as they are similar to previous changes (1)
- LICENSE.md
Contributor
|
Consent given in Discord, given here again! |
Contributor
|
Yes i agree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm changing the license of some (most) devices from GPL v3.0 to Apache License v2.0 with consent of the involved authors:
Summary by CodeRabbit