feat: secure BigQuery connection credentials - #2
Open
debba wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility
This change does not require migration of existing connections. The driver reads the new secure
credentialextra first and falls back to the existing Password value when it is absent.Older hosts ignore the additive
connection_fieldsmanifest property. When the secure secret API is unavailable, the UI continues to direct users to Password.Validation
pnpm --dir ui install --frozen-lockfilepnpm --dir ui typecheckpnpm --dir ui buildcargo test --all-targetscargo clippy --all-targets -- -D warningscargo fmt --all -- --checkcargo build --releaseDependencies
Publishing this manifest requires the corresponding Tabularis host support in TabularisDB/tabularis#629 and an update to the Tabularium driver schema so that
connection_fieldsis accepted by the registry validator.Closes #1