chore: security hardening for CI/CD and file permissions - #99
Merged
Conversation
- saxion-eduroam.py: write the pinned CA cert with 0600 instead of 0644; NetworkManager reads it as root regardless, so world-readable adds nothing but exposure (CodeQL alert #25). - update-checksums.yml: require the PR head repo to match the base repo before checking out and executing github.head_ref with a write token, closing the fork-PR pwn-request path CodeQL flagged (alert #24).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two security issues: (1) prevents execution of attacker-controlled scripts from forked PRs in the update-checksums workflow by validating the head repository, and (2) restricts CA certificate file permissions to owner-only access.