fix(ci): pin renovate checksum-update checkout to head sha - #100
Merged
Conversation
The update-checksums job checks out github.head_ref, a mutable branch name, with contents:write permissions. CodeQL flags this as an untrusted checkout even though the job's if: already restricts it to renovate[bot]'s own same-repo branches, because that guard isn't recognized as a mitigation for plain pull_request events. Pin the checkout to github.event.pull_request.head.sha instead, the fixed commit the triggering event actually refers to, which also closes a TOCTOU window where a later push to the branch could slip in commits the if: check never saw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 1 code scanning warning.