Rename Ads architecture diagram to bust stale CDN cache - #827
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This comment has been minimized.
This comment has been minimized.
Jeroen-Veltmans
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reworked Ads architecture diagram (#817) kept the same static filename
how_ads_works-{light,dark}.svg, so the CDN layer in front of the site (which caches static assets withmax-age=31536000and isn't purged by the CloudFront invalidation in the deploy workflow) keeps serving the old signaling-service diagram.how_ads_works-v2-{light,dark}.svg(a never-cached URL) andads/index.mdxupdated to reference it./ads/img/how_ads_works-{light,dark}.svgURL, moved fromads_versioned_docs/version-v1/static/— that directory isn't instaticDirectories, so the v1 docs pages (which still reference the original URL) were incorrectly showing the v2 diagram; they now correctly show the v1 diagram again.No other static assets were modified in place by #817, so this is the only asset with the stale-cache conflict.
Link to Devin session: https://dolby.devinenterprise.com/sessions/e5d8f394b68b4b049c0ee8f8ab076bdc
Requested by: @MaartenRimaux