Skip to content

Rename Ads architecture diagram to bust stale CDN cache - #827

Merged
MaartenRimaux merged 1 commit into
mainfrom
devin/1787574171-rename-ads-diagram
Aug 24, 2026
Merged

Rename Ads architecture diagram to bust stale CDN cache#827
MaartenRimaux merged 1 commit into
mainfrom
devin/1787574171-rename-ads-diagram

Conversation

@MaartenRimaux

Copy link
Copy Markdown
Contributor

Summary

The reworked Ads architecture diagram (#817) kept the same static filename how_ads_works-{light,dark}.svg, so the CDN layer in front of the site (which caches static assets with max-age=31536000 and isn't purged by the CloudFront invalidation in the deploy workflow) keeps serving the old signaling-service diagram.

  • New v2 diagram renamed to how_ads_works-v2-{light,dark}.svg (a never-cached URL) and ads/index.mdx updated to reference it.
  • The old diagram is restored at the original /ads/img/how_ads_works-{light,dark}.svg URL, moved from ads_versioned_docs/version-v1/static/ — that directory isn't in staticDirectories, so the v1 docs pages (which still reference the original URL) were incorrectly showing the v2 diagram; they now correctly show the v1 diagram again.

No other static assets were modified in place by #817, so this is the only asset with the stale-cache conflict.

Link to Devin session: https://dolby.devinenterprise.com/sessions/e5d8f394b68b4b049c0ee8f8ab076bdc
Requested by: @MaartenRimaux

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@theoplayer-bot

This comment has been minimized.

@MaartenRimaux
MaartenRimaux merged commit ff96a67 into main Aug 24, 2026
7 of 8 checks passed
@MaartenRimaux
MaartenRimaux deleted the devin/1787574171-rename-ads-diagram branch August 24, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants