Fix noIndex being enabled on production builds - #825
Merged
Conversation
Co-Authored-By: Mattias Buelens <mattias.buelens@dolby.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production builds were silently marked
noIndex, which makes@docusaurus/plugin-sitemapskip writingsitemap.xmlentirely (and adds<meta name="robots" content="noindex, nofollow">to every page — currently live on https://optiview.dolby.com/docs/).Cause: the workflow passes
docusaurus_no_index: 0for production, which reaches the config as the string"0", and!!'0' === true.PR previews (
docusaurus_no_index: 1) keepnoIndex: true.Verified with a local
DOCUSAURUS_NO_INDEX=0 npm run build:build/sitemap.xmlis now generated and no page contains anoindexrobots tag.Link to Devin session: https://dolby.devinenterprise.com/sessions/b3059def9f1642a3bc87a647c751cdce
Requested by: @MattiasBuelens