Fix handshake error with Geyser ping passthrough on Velocity#120
Open
MasonooN wants to merge 2 commits into
Open
Fix handshake error with Geyser ping passthrough on Velocity#120MasonooN wants to merge 2 commits into
MasonooN wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes spurious handshake/manipulation errors on Velocity when Geyser's ping
passthrough is enabled. Geyser pings arrive as a
GeyserInboundConnection,which isn't a real player connection the plugin can manipulate, but the
handler previously treated any unrecognized connection as
LEGACYand triedto disconnect/manipulate it, throwing errors.
Changes
UNKNOWNconnection type inVelocityPlayer. Connections are nowonly classified as
LEGACYwhen they actually matchHandshakeSessionHandler$LegacyInboundConnection; anything unrecognized(e.g. Geyser's ping passthrough connection) is marked
UNKNOWNinstead ofbeing misidentified as legacy.
UNKNOWNconnections inVelocityHandshakeHandler.handleEvent(),they're ignored silently rather than disconnected or manipulated.
build.gradlesonet.md-5:bungeecord-apiresolves (the Spigot snapshot repo now blocks automated builds).
velocity-plugin.jsonreformatted by the build'supdateVersiontask.Testing
gradle build, JDK 21).handshake errors no longer appear and normal Java/Bedrock connections still work.