fix: consolidate pool service#90
Open
Meet-hybrid wants to merge 1 commit into
Open
Conversation
EmeditWeb
reviewed
Jul 21, 2026
EmeditWeb
left a comment
Member
There was a problem hiding this comment.
Review verdict: ✅ APPROVE
Verified locally on this branch: build, lint, and test all pass (21 tests). The consolidation is correct — SponsorOnboarding now calls sponsorsService.getPoolInfo() (which exists and is identical to the removed poolService.getPoolInfo()), and the redundant src/services/pool.service.ts is deleted with no other references left.
Two notes:
- The change to
src/services/vouching.service.ts(_txHash→_) is unrelated to consolidating the pool service — but it's harmless and, usefully, it fixes the pre-existing lint error onmainthat is currently making every Web PR's CI red. Because of that, merging this PR first would un-red the other Web PRs' CI. - The PR's own CI shows red, but that appears stale — a fresh run should pass. Please re-trigger CI.
Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• ## Summary
Testing
Closes #57