feat: unify wallet transaction lifecycle (#55 #56 #66)#86
Conversation
|
Please merge |
|
please fix CI issues |
EmeditWeb
left a comment
There was a problem hiding this comment.
Review verdict: ✅ APPROVE
Nice unification — this net-removes ~140 lines while centralizing the transaction lifecycle in a dedicated transaction.service.ts with tests. Verified locally: build passes, lint is clean, tests pass (24). Standards check is clean: no hardcoded hex colors, no API calls in page components (pages delegate to the service/hooks), and no any in the new service.
The red CI appears stale (this branch is green locally). Please re-run it.
One suggestion (non-blocking): since this touches the signing→submit path, a quick manual smoke test of an end-to-end vouch/sponsor transaction in the browser before merge would be worthwhile — the automated tests cover the units but not the full wallet round-trip.
|
Please merge |
|
repush to trigger the CI workflow |
Closes #83
Summary
Closes #[issue number]
Briefly describe what this PR does in 2-3 sentences.
This repo is for the React web app only
This app targets sponsors, vendors, and mentors.
It does NOT serve learners. Learner features
belong in StepFi-App.
Before submitting, confirm your changes belong here:
contract code
Expo-specific code
(use Tailwind classes or constants/colors.ts)
(use services/ layer only)
Type of change
Testing
Context files reviewed
Mandatory before requesting review
Running these must all exit 0:
npm run lint
npm test
npm run build
If either fails, fix it before opening this PR.
PRs that reduce the test count will be rejected.
PRs with failing CI will be closed without review.