Improve Gardener setup#1230
Merged
Merged
Conversation
mbuechse
commented
Jun 22, 2026
mbuechse
commented
Contributor
- allow omitting machine_image_version
- allow specifying a volume via volume_size_gib
- account for state 'Pending' in plugin_gardener.py
- allow omitting machine_image_version - allow specifying a volume via volume_size_gib - account for state 'Pending' in plugin_gardener.py Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
fzakfeld
approved these changes
Jun 22, 2026
| version: {{ machine_image_version }} | ||
| name: {{ machine_image_name }}{% | ||
| if machine_image_version | default('') %} | ||
| version: {{ machine_image_version }}{% |
Contributor
There was a problem hiding this comment.
Not sure if this works but if someone else can confirm I'm happy with it
Contributor
Author
There was a problem hiding this comment.
I can confirm that it works. Cluster will be created and tests can be run (they are still running though)
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.