Skip to content

DO NOT MERGE S6541: reduce noise by dividing found issues count by 15 instead of 10 #5714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asya-vorobeva wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

DO NOT MERGE S6541: reduce noise by dividing found issues count by 15 instead of 10 #5714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions java-checks-test-sources/default/src/main/java/checks/BrainMethodCheckSubsetOfIssues.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package checks;

//The test unit is set to report the first brain method issue + the 10% of the total brain method issues found,
//The test unit is set to report the first brain method issue + the total brain method issues found divided by 15,
//ordered by general complexity.
//In this file there are 10 issues found, so a total of 1 + (10% of 10 = 1) = 2 issues will be raised
//In this file there are 10 issues found, so a total of 1 + (10 / 15 = 0) = 1 issue will be raised
class BrainMethodCheckSubsetOfIssues {

void method1(String a, String b) { // Noncompliant
void method1(String a, String b) { // Compliant: this will be skipped since the following method is more complex
if (a != null) {
System.out.println(a + b);
}
Expand Down
2 changes: 1 addition & 1 deletion java-checks/src/main/java/org/sonar/java/checks/design/BrainMethodCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ private static boolean isExcluded(MethodTree methodTree) {
@Override
public void endOfAnalysis(ModuleScannerContext context) {
if (issuesFound.size() > numberOfIssuesToReport) {
numberOfIssuesToReport += issuesFound.size() / 10;
numberOfIssuesToReport += issuesFound.size() / 15;
issuesFound.sort((a, b) -> b.brainScore - a.brainScore);
} else {
numberOfIssuesToReport = issuesFound.size();
Expand Down
Loading